Page MenuHomePhabricator

Fix trap instruction on pp64
ClosedPublic

Authored by espindola on Apr 19 2018, 11:45 AM.

Details

Reviewers
ruiu
sfertile
Summary

The test was passing on a big endian host, but just because od with x4 was compensating for it.

Diff Detail

Event Timeline

espindola created this revision.Apr 19 2018, 11:45 AM
ruiu accepted this revision.Apr 19 2018, 4:00 PM

LGTM

ELF/Arch/PPC64.cpp
97–98

Something like this would be a bit simpler:

TrapInstr = (Config->IsLE == sys::IsLittleEndianHost) ? ...;
This revision is now accepted and ready to land.Apr 19 2018, 4:00 PM