This is an archive of the discontinued LLVM Phabricator instance.

Fix BNF nits in TableGen language reference.
ClosedPublic

Authored by simon_tatham on Apr 19 2018, 7:58 AM.

Details

Summary

In the course of writing an experimental ANTLR grammar based on this
document, I found three errors in the documented BNF:

SimpleValues of dag type are allowed to have no operands at all after
the initial DagArg specifying the operator. For example, the value
(outs) is extremely common in backends; an example in the test suite
is test/TableGen/AsmVariant.td line 30. But the BNF doesn't allow
DagArgList to expand to the empty string (it must contain at least one
DagArg), and therefore the DagArgList specifying the operands in the
dag-shaped production for SimpleValue should be optional.

In the production for BodyItem with a 'let' and an optional RangeList,
the RangeList should have braces around it if it's present, matching
code such as "let E{7-0} = ..." on test/TableGen/BitsInit.td line 42.
Those braces aren't included in the RangeList nonterminal itself, so
instead they need to be part of the optional segment of the BodyItem
production.

Finally, the identifier after 'defm' should be optional. Again, this
is very common in the real back end .td files; an example in the test
suite is in test/TableGen/defmclass.td line 49.

Diff Detail

Event Timeline

simon_tatham created this revision.Apr 19 2018, 7:58 AM

Adding TableGen's code owner.

nhaehnle accepted this revision.Apr 19 2018, 11:45 AM

Thanks, LGTM.

This revision is now accepted and ready to land.Apr 19 2018, 11:45 AM
This revision was automatically updated to reflect the committed changes.