This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] Remove redundant specializations in type_traits.
AbandonedPublic

Authored by MaskRay on Apr 19 2018, 12:07 AM.

Details

Reviewers
EricWF
ldionne

Event Timeline

MaskRay created this revision.Apr 19 2018, 12:07 AM
ldionne added inline comments.
include/type_traits
595

It is not impossible that this was a compile-time optimization for the (probably very common) case where there's only 2 arguments. I'd like to have Marshall's input on that, since he seems to have written that code. Otherwise, LGTM. Ping @mclow.lists

ldionne accepted this revision.Mar 10 2020, 4:09 PM

LGTM, but you'll need to rebase this

This revision is now accepted and ready to land.Mar 10 2020, 4:09 PM
MaskRay abandoned this revision.Mar 10 2020, 4:43 PM

Thanks for review! However, I am abandoning this change because rL364160 deleted these traits.