Page MenuHomePhabricator

Rename ObjectMemoryBuffer to SmallVectorMemoryBuffer; NFCI
ClosedPublic

Authored by weimingz on Apr 14 2018, 10:36 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

weimingz created this revision.Apr 14 2018, 10:36 PM
dblaikie accepted this revision.Apr 15 2018, 7:51 PM

Fix up a few comments & then it seems fine.

include/llvm/Support/SmallVectorMemoryBuffer.h
1–2 ↗(On Diff #142538)

Please fix this comment so it still ends with "-*- C++ -*-==//" - maybe by removing the descriptive text, now that it's a bit redundant.

46–48 ↗(On Diff #142538)

Line wrapping (maybe just drop the indentation and put the "r-value and StringRef." at the end of the previous line.

This revision is now accepted and ready to land.Apr 15 2018, 7:51 PM
This revision was automatically updated to reflect the committed changes.