[CallSiteSplitting] Add missing pass dependency

[davide]

LGTM.

[davide]

There's a way to trigger this failure (that I don't remember off the top of my head). Mind to play around with this a little bit and see if you can write a test that triggers a crash?

[fhahn]

It would be great to know in which case this causes a crash. The pass currently should not rely on the DT, but if it is available, it will update it (it is using auto *DTWP = getAnalysisIfAvailable<DominatorTreeWrapperPass>();)

[trentxintong]

@davide @fhahn I will take a look!.

[fhahn]

Is this still an issue? If so, please add a test case. Requesting changes for now, to clear up my queue.

[trentxintong]

This is not an issue. Thanks @fhahn.

lib/Transforms/Scalar/CallSiteSplitting.cpp

return doCallSiteSplitting(F, TLI, TTI,
                                DTWP ? &DTWP->getDomTree() : nullptr);
   }
 };
 } // namespace
 
 char CallSiteSplittingLegacyPass::ID = 0;
 INITIALIZE_PASS_BEGIN(CallSiteSplittingLegacyPass, "callsite-splitting",
                       "Call-site splitting", false, false)
+INITIALIZE_PASS_DEPENDENCY(DominatorTreeWrapperPass)
 INITIALIZE_PASS_DEPENDENCY(TargetLibraryInfoWrapperPass)
 INITIALIZE_PASS_DEPENDENCY(TargetTransformInfoWrapperPass)
 INITIALIZE_PASS_END(CallSiteSplittingLegacyPass, "callsite-splitting",
                     "Call-site splitting", false, false)
 FunctionPass *llvm::createCallSiteSplittingPass() {
   return new CallSiteSplittingLegacyPass();
 }