- User Since
- Jul 17 2015, 4:04 PM (177 w, 2 d)
Wed, Nov 28
Mon, Nov 26
Address comments from @davidxl
Update comment in test case.
Thu, Nov 15
Address @tejohnson comment. Thanks!
Add the same thing to the new pass manager as suggested by @tejohnson
Wed, Nov 14
Nov 8 2018
Thanks for the change @fhahn. I will dig up my test case and run it.
This is not an issue. Thanks @fhahn.
Nov 5 2018
Update last bit of suggestions. Thanks for review @tejohnson.
Nov 4 2018
Address @tejohnson suggestions.
Oct 25 2018
Address @tejohson's suggestion to add test cases.
Oct 15 2018
Sure. I will add those tests. Thanks for spending time reviewing this @tejohnson!
Address @tejohnson suggesions. Thanks!
Address @tejohnson suggestions. Thanks!
Internalization leads to the possibility of changing the function ABI, better global modref AA, better chance of discarding an unused symbol, etc.
Oct 8 2018
Oct 7 2018
Oct 5 2018
Oct 4 2018
Sep 24 2018
D51550 has been accepted.
Sep 20 2018
Address @tejohnson comment by adding NFCs to commit msg and summary.
Sep 17 2018
Ping 2X. Thanks!
Sep 13 2018
collect some numbers on sqlite3.c
Sep 12 2018
LGTM. @efriedma, does this look good to you ? I think we have to have similar treatments for memcpyopt in the past.
Sep 11 2018
Aug 31 2018
This looks good to me. I will let @courbet to have the final say here.
Aug 24 2018
Aug 22 2018
Aug 20 2018
Thanks!. The approach I am considering is to bring in something, like a stub (e.g. the declaration completely unmapped, we cant map it fully anyways) and eventually using it as a handle to RAUW when we have properly mapped in the SGV. Do you think this would work ?
@evgeny777 Do you mind I give this bug a try ? Thanks.
Aug 12 2018
I dumped the Composite right after the 2nd file is merged. Things look good except the DITemplateValueParameter debuginfo looks a bit odd. Does this look correct to you ?
Aug 5 2018
Jul 26 2018
Jul 21 2018
Jul 19 2018
Jul 18 2018
Jul 16 2018
@fhahn Thank you for doing this. This is not a blocking issue for us. But it would be nice to have it fixed (for us and the possibly other users of LLVM in general). If you and @davide agree we should do this before having a real fix. I can write a test and land this. Otherwise, I am fine waiting for the real fix.
Address comments. Thanks @hfinkel
Jul 14 2018
This brings about 20ms - 25ms out of ~20s when compile sqlite3.c
Update diff addressing all of @hfinkel comments.
@hfinkel I get what you mean. Basically moving the IntrinsicInst check inside the call does not result us doing extra work when processing IntrinsicInst as we essentially do the same things in the dyn_cast<IntrinsicInst>. I will update the diff accordingly.
Address some of @hfinkel suggestions.
Thank you for taking a look at this code. I agree we should definitely "else" the StoreInst check and I have observed improvements in Xcode Instrument for doing so.
Jul 13 2018
Friendly Ping. Are there any problems with this patch ? Do I need to collect more #s ?
Jul 9 2018
Jun 22 2018
Hi @brzycki. This is a deficiency in a feature we already have. In jump threading, when we can tell all the predecessors of a block go to the same destination. we do not need to thread, we can just fold the terminator of the block. This has less impact on the CFG and also we do not have the problem of not being able to jump threading because the block can not be duplicated.
Jun 21 2018
Jun 18 2018
Address @asbirlea comments
Jun 17 2018
I think this makes sense. Except Jumpthreading needs to be modified to make sure iterator is valid after merging. I can work on the jump threading part once this lands and if you do not mind @brzycki.
Jun 16 2018
Remove some duplicate code.
Jun 14 2018
Handle when all destinations are null (i.e. UNDEF value). There is a slight change in pr22086.ll this is due
to we do not run SimplifyInstructionsInBlock after folding (we run after threading).
I am having some trouble with arc. Created this diff accidentally. Its a duplicate of https://reviews.llvm.org/D48181