Page MenuHomePhabricator

[WebAssembly] Fix a bug in MachineBasicBlock::findDebugLoc() call
ClosedPublic

Authored by aheejin on Apr 13 2018, 4:53 PM.

Details

Summary

InsertPos is within the bacic block Header, so findDebugLoc() should be called on not MBB but Header instead.

Diff Detail

Repository
rL LLVM

Event Timeline

aheejin created this revision.Apr 13 2018, 4:53 PM
aheejin edited the summary of this revision. (Show Details)Apr 13 2018, 4:54 PM
aheejin edited the summary of this revision. (Show Details)
aheejin edited the summary of this revision. (Show Details)
aheejin updated this revision to Diff 142495.Apr 13 2018, 4:55 PM

comment fix

aheejin edited the summary of this revision. (Show Details)Apr 13 2018, 4:55 PM
aheejin retitled this revision from [WebAssembly] Fix a bug in MachineBasicBlock::findDebugLoc() call to [WebAssembly] Fix bugs in MachineBasicBlock::findDebugLoc() call.
aheejin retitled this revision from [WebAssembly] Fix bugs in MachineBasicBlock::findDebugLoc() call to [WebAssembly] Fix bugs in MachineBasicBlock::findDebugLoc() calls.Apr 13 2018, 4:57 PM
aheejin edited the summary of this revision. (Show Details)Apr 13 2018, 5:06 PM
aheejin edited the summary of this revision. (Show Details)
aheejin updated this revision to Diff 142497.Apr 13 2018, 5:10 PM

Delete findPrevDebugLoc() call and leave only Header bugfix

aheejin retitled this revision from [WebAssembly] Fix bugs in MachineBasicBlock::findDebugLoc() calls to [WebAssembly] Fix a bug in MachineBasicBlock::findDebugLoc() call.Apr 13 2018, 5:10 PM
aheejin edited the summary of this revision. (Show Details)
yurydelendik accepted this revision.Apr 13 2018, 5:14 PM

This makes sense. Thank you for the patch.

This revision is now accepted and ready to land.Apr 13 2018, 5:14 PM
This revision was automatically updated to reflect the committed changes.