We do not need nonull attribute if we know an argument is going to be constant.
Thanks for handling this. Just curious if you see any issue with the non-null attribute in a constant ?
|44 ↗||(On Diff #142330)|
Can you move this in callsite-split-or-phi.ll where we run only callsite-splitting pass. Looks like you can also use just like i32* instead of %struct.bitmap*.
LGTM, with the test simplification. Unfortunately there is no easy way to prevent adding the unnecessary nonnull attribute in first place.
|577 ↗||(On Diff #143492)|
Do we need inttoptr here?
|590 ↗||(On Diff #143492)|
I don't think we need a complex callee2 function that's called here. Could you just use the existing callee function?