Page MenuHomePhabricator

[clang-apply-replacements] Fix a link failure in applyChanges()
AbandonedPublic

Authored by aheejin on Apr 12 2018, 12:08 AM.

Details

Reviewers
jdemeule
Summary

This call to tooling::applyAtomicChanges() introduced in D43764 (rL329813) caused a undefined reference error when built with -DBUILD_SHARED_LIB=ON.

Event Timeline

aheejin created this revision.Apr 12 2018, 12:08 AM
aheejin edited the summary of this revision. (Show Details)Apr 12 2018, 12:09 AM
aheejin retitled this revision from Fix a link failure in applyChanges() to [clang-apply-replacements] Fix a link failure in applyChanges().Apr 12 2018, 12:13 AM
aheejin edited the summary of this revision. (Show Details)
jdemeule accepted this revision.Apr 12 2018, 3:59 AM
This revision is now accepted and ready to land.Apr 12 2018, 3:59 AM
aheejin abandoned this revision.Apr 12 2018, 4:09 AM

Looks like the same patch rL329892 has already landed.

Looks like the same patch rL329892 has already landed.

Sorry, somehow i missed this differential.