This is an archive of the discontinued LLVM Phabricator instance.

Differential D45555

[clang-apply-replacements] Fix a link failure in applyChanges()
AbandonedPublic

Authored by aheejin on Apr 12 2018, 12:08 AM.

Details

Reviewers
jdemeule
Summary

This call to tooling::applyAtomicChanges() introduced in D43764 (rL329813) caused a undefined reference error when built with -DBUILD_SHARED_LIB=ON.

Diff Detail

Event Timeline

aheejin created this revision.Apr 12 2018, 12:08 AM
Herald added subscribers: cfe-commits, mgorny, klimek. · View Herald TranscriptApr 12 2018, 12:08 AM
aheejin edited the summary of this revision. (Show Details)Apr 12 2018, 12:09 AM
aheejin retitled this revision from Fix a link failure in applyChanges() to [clang-apply-replacements] Fix a link failure in applyChanges().Apr 12 2018, 12:13 AM
aheejin edited the summary of this revision. (Show Details)
jdemeule accepted this revision.Apr 12 2018, 3:59 AM
This revision is now accepted and ready to land.Apr 12 2018, 3:59 AM
aheejin abandoned this revision.Apr 12 2018, 4:09 AM

Looks like the same patch rL329892 has already landed.

lebedev.ri added a subscriber: lebedev.ri.Apr 12 2018, 4:45 AM
In D45555#1065387, @aheejin wrote:

Looks like the same patch rL329892 has already landed.

Sorry, somehow i missed this differential.

Revision Contents

PathSize
clang-apply-replacements/
1 line

Diff 142120

clang-apply-replacements/CMakeLists.txt

set(LLVM_LINK_COMPONENTS set(LLVM_LINK_COMPONENTS
Support Support
) )
add_clang_library(clangApplyReplacements add_clang_library(clangApplyReplacements
lib/Tooling/ApplyReplacements.cpp lib/Tooling/ApplyReplacements.cpp
LINK_LIBS LINK_LIBS
clangAST clangAST
clangBasic clangBasic
clangRewrite clangRewrite
clangToolingCore clangToolingCore
clangToolingRefactor
) )
include_directories( include_directories(
${CMAKE_CURRENT_SOURCE_DIR} ${CMAKE_CURRENT_SOURCE_DIR}
include include
) )
add_subdirectory(tool) add_subdirectory(tool)