Page MenuHomePhabricator

[clang-format] Improve ObjC guessing heuristic by supporting all @keywords
ClosedPublic

Authored by benhamilton on Apr 11 2018, 8:33 AM.

Details

Summary

This diff improves the Objective-C guessing heuristic by
replacing the hard-coded list of a subset of Objective-C @keywords
with a general check which supports all @keywords.

I also added a few more Foundation keywords which were missing from
the heuristic.

Test Plan: Unit tests updated. Ran tests with:

% make -j16 FormatTests && ./tools/clang/unittests/Format/FormatTests

Diff Detail

Repository
rL LLVM

Event Timeline

benhamilton created this revision.Apr 11 2018, 8:33 AM
djasper accepted this revision.Apr 12 2018, 5:31 AM

Looks good.

This revision is now accepted and ready to land.Apr 12 2018, 5:31 AM
This revision was automatically updated to reflect the committed changes.