Page MenuHomePhabricator

[clang-format] Don't remove empty lines before namespace endings
ClosedPublic

Authored by krasimir on Apr 6 2018, 8:29 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

krasimir created this revision.Apr 6 2018, 8:29 AM
djasper accepted this revision.Apr 19 2018, 5:14 AM

Looks good.

lib/Format/NamespaceEndCommentsFixer.h
24 ↗(On Diff #141352)

I don't understand the "if that is to be formatted part". What do you mean?

This revision is now accepted and ready to land.Apr 19 2018, 5:14 AM
krasimir marked an inline comment as done.Apr 19 2018, 5:18 AM
krasimir added inline comments.
lib/Format/NamespaceEndCommentsFixer.h
24 ↗(On Diff #141352)

I'm documenting the current behavior of the implementation, getting into more detail in the next paragraph of the comments: this returns nullptr if Line is not Affected, even if otherwise would have a namespace token.

This revision was automatically updated to reflect the committed changes.
krasimir marked an inline comment as done.