[AArch64] Reserve x18 register on Fuchsia

[phosek]

Summary

This register is reserved as a platform register on Fuchsia.

[mcgrathr]

lgtm

llvm/lib/Target/AArch64/AArch64Subtarget.cpp

void AArch64Subtarget::initializeProperties() {
   case Others: break;
   }
 }
 
 AArch64Subtarget::AArch64Subtarget(const Triple &TT, const std::string &CPU,
                                    const std::string &FS,
                                    const TargetMachine &TM, bool LittleEndian)
     : AArch64GenSubtargetInfo(TT, CPU, FS),
-      ReserveX18(TT.isOSDarwin() || TT.isOSWindows()), IsLittle(LittleEndian),
-      TargetTriple(TT), FrameLowering(),
+      ReserveX18(TT.isOSDarwin() || TT.isOSFuchsia() || TT.isOSWindows()),
+      IsLittle(LittleEndian), TargetTriple(TT), FrameLowering(),
       InstrInfo(initializeSubtargetDependencies(FS, CPU)), TSInfo(),
       TLInfo(TM, *this) {
   CallLoweringInfo.reset(new AArch64CallLowering(*getTargetLowering()));
   Legalizer.reset(new AArch64LegalizerInfo(*this));
 
   auto *RBI = new AArch64RegisterBankInfo(*getRegisterInfo());
 
   // FIXME: At this point, we can't rely on Subtarget having RBI.

llvm/test/CodeGen/AArch64/aarch64-named-reg-w18.ll

-; RUN: not llc -mtriple=aarch64-fuchsia -o - %s 2>&1 | FileCheck %s --check-prefix=ERROR
-; RUN: llc -mtriple=aarch64-fuchsia -mattr=+reserve-x18 -o - %s
+; RUN: llc -mtriple=aarch64-fuchsia -o - %s
 
 define void @set_w18(i32 %x) {
 entry:
 ; FIXME: Include an allocatable-specific error message
-; ERROR: Invalid register name "w18".
   tail call void @llvm.write_register.i32(metadata !0, i32 %x)
   ret void
 }
 
 declare void @llvm.write_register.i32(metadata, i32) nounwind
 
 !0 = !{!"w18"}

llvm/test/CodeGen/AArch64/aarch64-named-reg-x18.ll

-; RUN: not llc -mtriple=aarch64-fuchsia -o - %s 2>&1 | FileCheck %s --check-prefix=ERROR
-; RUN: llc -mtriple=aarch64-fuchsia -mattr=+reserve-x18 -o - %s
+; RUN: llc -mtriple=aarch64-fuchsia -o - %s
 
 define void @set_x18(i64 %x) {
 entry:
 ; FIXME: Include an allocatable-specific error message
-; ERROR: Invalid register name "x18".
   tail call void @llvm.write_register.i64(metadata !0, i64 %x)
   ret void
 }
 
 declare void @llvm.write_register.i64(metadata, i64) nounwind
 
 !0 = !{!"x18"}

llvm/test/CodeGen/AArch64/arm64-platform-reg.ll

 ; RUN: llc -mtriple=arm64-apple-ios -mattr=+reserve-x18 -o - %s | FileCheck %s --check-prefix=CHECK-RESERVE-X18
 ; RUN: llc -mtriple=arm64-freebsd-gnu -mattr=+reserve-x18 -o - %s | FileCheck %s --check-prefix=CHECK-RESERVE-X18
 ; RUN: llc -mtriple=arm64-linux-gnu -o - %s | FileCheck %s
+; RUN: llc -mtriple=aarch64-fuchsia -o - %s | FileCheck %s --check-prefix=CHECK-RESERVE-X18
 ; RUN: llc -mtriple=aarch64-windows -o - %s | FileCheck %s --check-prefix=CHECK-RESERVE-X18
 
 ; x18 is reserved as a platform register on Darwin but not on other
 ; systems. Create loads of register pressure and make sure this is respected.
 
 ; Also, fp must always refer to a valid frame record, even if it's not the one
 ; of the current function, so it shouldn't be used either.