This is an archive of the discontinued LLVM Phabricator instance.

Differential D45081

[analyzer] Remove the unused method declaration in `ValistChecker.cpp`.
ClosedPublic

Authored by MTC on Mar 30 2018, 4:51 AM.

Details

Reviewers
xazax.hun
george.karpenkov
Commits
rGf1a0ff755a9f: [analyzer] Remove the unused method declaration in `ValistChecker.cpp`.
rL328860: [analyzer] Remove the unused method declaration in `ValistChecker.cpp`.
rC328860: [analyzer] Remove the unused method declaration in `ValistChecker.cpp`.
Summary

getVariableNameFromRegion() seems useless.

Diff Detail

Repository
rC Clang

Event Timeline

MTC created this revision.Mar 30 2018, 4:51 AM
Herald added a reviewer: george.karpenkov. · View Herald TranscriptMar 30 2018, 4:51 AM
Herald added subscribers: cfe-commits, a.sidorin, rnkovacs, szepet. · View Herald Transcript
Harbormaster completed remote builds in B16587: Diff 140408.Mar 30 2018, 4:52 AM
xazax.hun accepted this revision.Mar 30 2018, 5:09 AM

LG! Thanks!

This revision is now accepted and ready to land.Mar 30 2018, 5:09 AM
Closed by commit rC328860: [analyzer] Remove the unused method declaration in `ValistChecker.cpp`. (authored by henrywong). · Explain WhyMar 30 2018, 6:41 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
StaticAnalyzer/
Checkers/
1 line

Diff 140419

lib/StaticAnalyzer/Checkers/ValistChecker.cpp

Show First 20 Lines • Show All 50 Lines • ▼ Show 20 Linespublic:
void checkPreStmt(const VAArgExpr *VAA, CheckerContext &C) const; void checkPreStmt(const VAArgExpr *VAA, CheckerContext &C) const;
void checkPreCall(const CallEvent &Call, CheckerContext &C) const; void checkPreCall(const CallEvent &Call, CheckerContext &C) const;
void checkDeadSymbols(SymbolReaper &SR, CheckerContext &C) const; void checkDeadSymbols(SymbolReaper &SR, CheckerContext &C) const;
private: private:
const MemRegion *getVAListAsRegion(SVal SV, const Expr *VAExpr, const MemRegion *getVAListAsRegion(SVal SV, const Expr *VAExpr,
bool &IsSymbolic, CheckerContext &C) const; bool &IsSymbolic, CheckerContext &C) const;
StringRef getVariableNameFromRegion(const MemRegion *Reg) const;
const ExplodedNode *getStartCallSite(const ExplodedNode *N, const ExplodedNode *getStartCallSite(const ExplodedNode *N,
const MemRegion *Reg) const; const MemRegion *Reg) const;
void reportUninitializedAccess(const MemRegion *VAList, StringRef Msg, void reportUninitializedAccess(const MemRegion *VAList, StringRef Msg,
CheckerContext &C) const; CheckerContext &C) const;
void reportLeakedVALists(const RegionVector &LeakedVALists, StringRef Msg1, void reportLeakedVALists(const RegionVector &LeakedVALists, StringRef Msg1,
StringRef Msg2, CheckerContext &C, ExplodedNode *N, StringRef Msg2, CheckerContext &C, ExplodedNode *N,
bool ReportUninit = false) const; bool ReportUninit = false) const;
▲ Show 20 Lines • Show All 348 Lines • Show Last 20 Lines