This is an archive of the discontinued LLVM Phabricator instance.

Differential D45058

[X86] Disable SGX for Skylake Server
ClosedPublic

Authored by GBuella on Mar 29 2018, 11:48 AM.

Details

Reviewers
craig.topper
zvi
echristo
Commits
rGe3330c1b6110: [X86] Disable SGX for Skylake Server
rC329701: [X86] Disable SGX for Skylake Server
rL329701: [X86] Disable SGX for Skylake Server

Diff Detail

Repository
rC Clang

Event Timeline

GBuella created this revision.Mar 29 2018, 11:48 AM
Herald added a subscriber: cfe-commits. · View Herald TranscriptMar 29 2018, 11:48 AM
craig.topper accepted this revision.Mar 29 2018, 9:43 PM

LGTM

This revision is now accepted and ready to land.Mar 29 2018, 9:43 PM
Closed by commit rL329701: [X86] Disable SGX for Skylake Server (authored by GBuella). · Explain WhyApr 10 2018, 7:10 AM
Closed by commit rC329701: [X86] Disable SGX for Skylake Server (authored by GBuella). · Explain Why
This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptApr 10 2018, 7:10 AM
davezarzycki added a subscriber: davezarzycki.Apr 10 2018, 7:29 AM
This comment was removed by davezarzycki.

Revision Contents

PathSize
lib/
Basic/
Targets/
3 lines

Diff 141839

lib/Basic/Targets/X86.cpp

Show First 20 Lines • Show All 176 Lines • ▼ Show 20 Lines case CK_SkylakeServer:
setFeatureEnabledImpl(Features, "pku", true); setFeatureEnabledImpl(Features, "pku", true);
if (Kind != CK_Cannonlake) // CNL inherits all SKX features, except CLWB if (Kind != CK_Cannonlake) // CNL inherits all SKX features, except CLWB
setFeatureEnabledImpl(Features, "clwb", true); setFeatureEnabledImpl(Features, "clwb", true);
LLVM_FALLTHROUGH; LLVM_FALLTHROUGH;
case CK_SkylakeClient: case CK_SkylakeClient:
setFeatureEnabledImpl(Features, "xsavec", true); setFeatureEnabledImpl(Features, "xsavec", true);
setFeatureEnabledImpl(Features, "xsaves", true); setFeatureEnabledImpl(Features, "xsaves", true);
setFeatureEnabledImpl(Features, "mpx", true); setFeatureEnabledImpl(Features, "mpx", true);
if (Kind != CK_SkylakeServer) // SKX inherits all SKL features, except SGX
setFeatureEnabledImpl(Features, "sgx", true); setFeatureEnabledImpl(Features, "sgx", true);
setFeatureEnabledImpl(Features, "clflushopt", true); setFeatureEnabledImpl(Features, "clflushopt", true);
setFeatureEnabledImpl(Features, "rtm", true); setFeatureEnabledImpl(Features, "rtm", true);
LLVM_FALLTHROUGH; LLVM_FALLTHROUGH;
case CK_Broadwell: case CK_Broadwell:
setFeatureEnabledImpl(Features, "rdseed", true); setFeatureEnabledImpl(Features, "rdseed", true);
setFeatureEnabledImpl(Features, "adx", true); setFeatureEnabledImpl(Features, "adx", true);
setFeatureEnabledImpl(Features, "prfchw", true); setFeatureEnabledImpl(Features, "prfchw", true);
LLVM_FALLTHROUGH; LLVM_FALLTHROUGH;
▲ Show 20 Lines • Show All 1,519 Lines • Show Last 20 Lines