This is an archive of the discontinued LLVM Phabricator instance.

Differential D44952

AMDGPU: Really implement getFrameRegister
ClosedPublic

Authored by arsenm on Mar 27 2018, 1:29 PM.

Details

Reviewers
kzhuravl
rampitec
Summary

Currently this seems to only really be used for debug info.

Diff Detail

Event Timeline

arsenm created this revision.Mar 27 2018, 1:29 PM
Herald added subscribers: JDevlieghere, t-tye, tpr and 5 others. · View Herald TranscriptMar 27 2018, 1:29 PM
kzhuravl accepted this revision.Mar 27 2018, 1:33 PM

LGTM.

This revision is now accepted and ready to land.Mar 27 2018, 1:33 PM
arsenm closed this revision.Mar 27 2018, 4:30 PM

r328677

Revision Contents

PathSize
lib/
Target/
AMDGPU/
3 lines
test/
DebugInfo/
AMDGPU/
3 lines

Diff 139992

lib/Target/AMDGPU/AMDGPURegisterInfo.cpp

Show First 20 Lines • Show All 76 Lines • ▼ Show 20 Linesconst uint32_t *SIRegisterInfo::getCallPreservedMask(const MachineFunction &MF,
case CallingConv::Cold: case CallingConv::Cold:
return CSR_AMDGPU_HighRegs_RegMask; return CSR_AMDGPU_HighRegs_RegMask;
default: default:
return nullptr; return nullptr;
} }
} }
unsigned SIRegisterInfo::getFrameRegister(const MachineFunction &MF) const { unsigned SIRegisterInfo::getFrameRegister(const MachineFunction &MF) const {
return AMDGPU::NoRegister; const SIMachineFunctionInfo *FuncInfo = MF.getInfo<SIMachineFunctionInfo>();
return FuncInfo->getFrameOffsetReg();
} }

test/DebugInfo/AMDGPU/variable-locations.ll

Show All 25 Lines
; CHECK-NEXT: DW_AT_name {{.*}}"GlobB" ; CHECK-NEXT: DW_AT_name {{.*}}"GlobB"
; CHECK-NEXT: DW_AT_type ; CHECK-NEXT: DW_AT_type
; CHECK-NEXT: DW_AT_external ; CHECK-NEXT: DW_AT_external
; CHECK-NEXT: DW_AT_decl_file ; CHECK-NEXT: DW_AT_decl_file
; CHECK-NEXT: DW_AT_decl_line ; CHECK-NEXT: DW_AT_decl_line
; CHECK-NEXT: DW_AT_location [DW_FORM_block1] (DW_OP_addr 0x0) ; CHECK-NEXT: DW_AT_location [DW_FORM_block1] (DW_OP_addr 0x0)
@GlobB = common addrspace(1) global i32 0, align 4, !dbg !6 @GlobB = common addrspace(1) global i32 0, align 4, !dbg !6
; CHECK: {{.*}}DW_TAG_subprogram
; CHECK: DW_AT_frame_base [DW_FORM_block1] (DW_OP_reg9 SGPR9)
define amdgpu_kernel void @kernel1( define amdgpu_kernel void @kernel1(
; CHECK: {{.*}}DW_TAG_formal_parameter ; CHECK: {{.*}}DW_TAG_formal_parameter
; CHECK-NEXT: DW_AT_location [DW_FORM_block1] (DW_OP_fbreg +4, DW_OP_constu 0x1, DW_OP_swap, DW_OP_xderef) ; CHECK-NEXT: DW_AT_location [DW_FORM_block1] (DW_OP_fbreg +4, DW_OP_constu 0x1, DW_OP_swap, DW_OP_xderef)
; CHECK-NEXT: DW_AT_name {{.*}}"ArgN" ; CHECK-NEXT: DW_AT_name {{.*}}"ArgN"
i32 %ArgN, i32 %ArgN,
; CHECK: {{.*}}DW_TAG_formal_parameter ; CHECK: {{.*}}DW_TAG_formal_parameter
; CHECK-NEXT: DW_AT_location [DW_FORM_block1] (DW_OP_fbreg +8, DW_OP_constu 0x1, DW_OP_swap, DW_OP_xderef) ; CHECK-NEXT: DW_AT_location [DW_FORM_block1] (DW_OP_fbreg +8, DW_OP_constu 0x1, DW_OP_swap, DW_OP_xderef)
; CHECK-NEXT: DW_AT_name {{.*}}"ArgA" ; CHECK-NEXT: DW_AT_name {{.*}}"ArgA"
▲ Show 20 Lines • Show All 70 Lines • Show Last 20 Lines