This is an archive of the discontinued LLVM Phabricator instance.

Revert "Revert "[lit] Generalized /dev/null support on Windows.""
ClosedPublic

Authored by mtrofin on Mar 26 2018, 5:56 PM.

Details

Summary

This reverts commit r328596.

Checking if the arguments are strings before testing if they contain "/dev/null".

Diff Detail

Event Timeline

mtrofin created this revision.Mar 26 2018, 5:56 PM
mtrofin added a reviewer: rnk.Mar 26 2018, 5:56 PM
rnk accepted this revision.Mar 26 2018, 6:13 PM

Please use SVN revisions instead of git shas in the commit message. There are many git mirrors of LLVM with different shas.

Otherwise, looks good!

This revision is now accepted and ready to land.Mar 26 2018, 6:13 PM
mtrofin edited the summary of this revision. (Show Details)Mar 26 2018, 6:39 PM
This revision was automatically updated to reflect the committed changes.