This is an archive of the discontinued LLVM Phabricator instance.

[DAG, X86] Fix ISel-time node insertion ids
ClosedPublic

Authored by niravd on Mar 22 2018, 11:39 AM.

Details

Summary

As in SystemZ backend, correctly propagate node ids when inserting new
unselected nodes into the DAG during instruction Seleciton for X86
target.

Fixes PR36865.

Diff Detail

Event Timeline

niravd created this revision.Mar 22 2018, 11:39 AM
niravd updated this revision to Diff 139486.Mar 22 2018, 11:45 AM

Remove unrelated fixup.

niravd retitled this revision from [MC,X86] Cleanup some X86 parser functions to use MCParser helpers. NFCI. to [DAG, X86] Fix ISel-time node insertion ids.Mar 22 2018, 11:45 AM
niravd edited the summary of this revision. (Show Details)
jyknight accepted this revision.Mar 22 2018, 11:55 AM

LG after resolving comment.

llvm/include/llvm/CodeGen/SelectionDAGISel.h
113

Some comments about what these are for would be good to have here.

This revision is now accepted and ready to land.Mar 22 2018, 11:55 AM
This revision was automatically updated to reflect the committed changes.