Fix LLVMDumpType() #ifdefed

[brenton]

Summary

Getting this error when using the LLVM C API and linking to a Release build

"Undefined symbols for architecture x86_64:
  \"_LLVMDumpType\", referenced from:
      _LLVMLink_LLVMDumpType_Wrapper in llvmc60.cpp.o
     (maybe you meant: _LLVMLink_LLVMDumpType_Wrapper)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see \
invocation)
make[2]: *** [LLVMLink.dylib] Error 1
make[1]: *** [CMakeFiles/LLVMLink.dir/all] Error 2
make: *** [all] Error 2
"

This fixes 34633

https://bugs.llvm.org/show_bug.cgi?id=34633

[brenton]

dump() method seems to have been removed.

Use LLVMDumpValue() as a model

[sammccall]

This makes sense to me, though I'm not an expert here so @MatzeB might want to confirm.

My r293460 was just unbreaking our build by reverting part of r293359, I don't know whether these functions *should* be exposed or not.

[brenton]

I just wanted to follow suit with what other functions are doing, e.g., LLVMDumpModule.

[brenton]

I cannot merge this. I do not have permissions.

I was also wondering about getting this into 6.0.1 ?

[brenton]

@sammccall Could you merge this?

[brenton]

@whitequark It looks like you may be taking over the C API? I was wondering if you could look at this and merge it. This has stalled a bit and I'd like to wrap this up.

[whitequark]

Thanks for the patch! Can you also remove LLVM_DUMP_METHOD here and elsewhere in the C API? It doesn't do anything useful.

[brenton]

Also remove LLVM_DUMP_METHOD at the request of whitequark

[brenton]

@whitequark I've removed LLVM_DUMP_METHOD. Let me know if there is anything else that should be done. I'm keen on getting this into 6.0.1

[whitequark]

Um, sorry, I mean only in the C API (extern "C" LLVM* methods). LLVM_DUMP_METHOD *does* serve a function in the C++ API.

[brenton]

Only remove LLVM_DUMP_METHOD from C API functions

[brenton]

@whitequark Sorry about that. I believe that LLVMDumpType and LLVMDumpValue are the only C API functions

llvm/trunk/lib/IR/Core.cpp

 {
     return unwrap(Ty)->isSized();
 }
 
 LLVMContextRef LLVMGetTypeContext(LLVMTypeRef Ty) {
   return wrap(&unwrap(Ty)->getContext());
 }
 
-#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
-LLVM_DUMP_METHOD void LLVMDumpType(LLVMTypeRef Ty) {
-  return unwrap(Ty)->dump();
+void LLVMDumpType(LLVMTypeRef Ty) {
+  return unwrap(Ty)->print(errs(), /*IsForDebug=*/true);
 }
-#endif
 
 char *LLVMPrintTypeToString(LLVMTypeRef Ty) {
   std::string buf;
   raw_string_ostream os(buf);
 
   if (unwrap(Ty))
     unwrap(Ty)->print(os);
   else

 const char *LLVMGetValueName(LLVMValueRef Val) {
   return unwrap(Val)->getName().data();
 }
 
 void LLVMSetValueName(LLVMValueRef Val, const char *Name) {
   unwrap(Val)->setName(Name);
 }
 
-LLVM_DUMP_METHOD void LLVMDumpValue(LLVMValueRef Val) {
+void LLVMDumpValue(LLVMValueRef Val) {
   unwrap(Val)->print(errs(), /*IsForDebug=*/true);
 }
 
 char* LLVMPrintValueToString(LLVMValueRef Val) {
   std::string buf;
   raw_string_ostream os(buf);
 
   if (unwrap(Val))