This is an archive of the discontinued LLVM Phabricator instance.

[LLVM-C] Finish exception instruction bindings
ClosedPublic

Authored by CodaFi on Mar 14 2018, 2:56 PM.

Details

Summary

Add support for cleanupret, catchret, catchpad, cleanuppad and catchswitch and their associated accessors.

Test is modified from SimplifyCFG because it contains many diverse usages of these instructions.

Diff Detail

Repository
rL LLVM

Event Timeline

CodaFi created this revision.Mar 14 2018, 2:56 PM

This looks reasonable to me, but I'm not familiar with funclet EH, so I'd like someone else to take a second look.

lib/IR/Core.cpp
2198–2199

Nit: I think this comment isn't valid anymore. Also below.

@whitequark can you recommend someone for review?

echristo accepted this revision.Mar 28 2018, 3:46 PM

OK.

tools/llvm-c-test/echo.cpp
679

Nit: No braces here. (possibly other places).

This revision is now accepted and ready to land.Mar 28 2018, 3:46 PM
CodaFi updated this revision to Diff 140185.Mar 28 2018, 8:42 PM
CodaFi marked 2 inline comments as done.

Respond to review nits

This revision was automatically updated to reflect the committed changes.