MIPS does not use PIC level 2 for historical reasons, even with -fPIC/-mxgot/multigot options.
This patch makes Clang behave more like GCC.
This patch looks mostly ok, but I think there are some small issues with it.
Can you separate the new warnings/error relating to -fno-pic / -mabicalls into another patch from the change which alters the behaviour of PIC / pic ?
The title of the patch is misleading, as you're adding warnings related to -fno-pic / -mabicalls and changing how pic is defined.
|983 ↗||(On Diff #139110)|
Can you reformulate this comment to say that MIPS does not use PIC level 2? Also, please add a note stating that even with -mxgot / -fPIC / multigot , MIPS does not use PIC level 2 unlike other architecutres for historical reasons.