Page MenuHomePhabricator

[WebAssembly] Avoid COMDAT hashmap lookup for each symbol. NFC

Authored by ncw on Mar 9 2018, 5:23 PM.



This reduces the number of lookups to one per COMDAT group, rather than one per symbol in a COMDAT group.

See D44343

Diff Detail


Event Timeline

ncw created this revision.Mar 9 2018, 5:23 PM
ncw added a comment.Mar 13 2018, 2:32 AM

I'm hoping this one can be approved too, since it goes along with D44343. Any objections?

sbc100 accepted this revision.Mar 13 2018, 11:43 AM
sbc100 added inline comments.
165 ↗(On Diff #137879)

I feel like it would be good to have some kind of wasm::kInvalidIndex that we could use here and elsewhere. But thats a separate change.

This revision is now accepted and ready to land.Mar 13 2018, 11:43 AM
This revision was automatically updated to reflect the committed changes.