Page MenuHomePhabricator

[ConstantFold] fp_binop undef, undef --> undef
ClosedPublic

Authored by spatel on Mar 8 2018, 9:56 AM.

Details

Summary

I don't think there's any controversy about this case, and it seems independent of any LangRef edits (D44216).

I tried to fix tests that would fold away:
rL327004
rL327028
rL327030
rL327034

I'm not sure if the Reassociate tests are meaningless yet, but they probably will be as we add more folds, so if anyone has suggestions or wants to fix those, please do.

Diff Detail

Event Timeline

spatel created this revision.Mar 8 2018, 9:56 AM
efriedma accepted this revision.Mar 8 2018, 11:04 AM

LGTM

I'm not sure what fp-expr.ll is trying to test, but I think we're fine as long as it doesn't crash.

This revision is now accepted and ready to land.Mar 8 2018, 11:04 AM
This revision was automatically updated to reflect the committed changes.