This is an archive of the discontinued LLVM Phabricator instance.

[analyzer] [PointerArithChecker] do not warn on indexes into vector types
ClosedPublic

Authored by george.karpenkov on Mar 6 2018, 1:23 PM.

Reviewers

dcoughlin
NoQ

Commits

Yup, looks like an obvious omission.

This revision is now accepted and ready to land.Mar 7 2018, 11:30 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

lib/

StaticAnalyzer/

Checkers/

4 lines

test/

Analysis/

6 lines

	Show First 20 Lines • Show All 302 Lines • ▼ Show 20 Lines

	void PointerArithChecker::checkPreStmt(const ArraySubscriptExpr *SubsExpr,			void PointerArithChecker::checkPreStmt(const ArraySubscriptExpr *SubsExpr,
	CheckerContext &C) const {			CheckerContext &C) const {
	SVal Idx = C.getSVal(SubsExpr->getIdx());			SVal Idx = C.getSVal(SubsExpr->getIdx());

	// Indexing with 0 is OK.			// Indexing with 0 is OK.
	if (Idx.isZeroConstant())			if (Idx.isZeroConstant())
	return;			return;

				// Indexing vector-type expressions is also OK.
				if (SubsExpr->getBase()->getType()->isVectorType())
				return;
	reportPointerArithMisuse(SubsExpr->getBase(), C);			reportPointerArithMisuse(SubsExpr->getBase(), C);
	}			}

	void PointerArithChecker::checkPreStmt(const BinaryOperator *BOp,			void PointerArithChecker::checkPreStmt(const BinaryOperator *BOp,
	CheckerContext &C) const {			CheckerContext &C) const {
	BinaryOperatorKind OpKind = BOp->getOpcode();			BinaryOperatorKind OpKind = BOp->getOpcode();
	if (!BOp->isAdditiveOp() && OpKind != BO_AddAssign && OpKind != BO_SubAssign)			if (!BOp->isAdditiveOp() && OpKind != BO_AddAssign && OpKind != BO_SubAssign)
	return;			return;
	Show All 23 Lines

Show First 20 Lines • Show All 341 Lines • ▼ Show 20 Lines	void negativeIndex(char *str) {
clang_analyzer_eval(*ptr3 == 'a'); // expected-warning{{UNKNOWN}}		clang_analyzer_eval(*ptr3 == 'a'); // expected-warning{{UNKNOWN}}
}		}

void test_no_crash_on_pointer_to_label() {		void test_no_crash_on_pointer_to_label() {
char *a = &&label;		char *a = &&label;
a[0] = 0;		a[0] = 0;
label:;		label:;
}		}

		typedef __attribute__((__ext_vector_type__(2))) float simd_float2;
		float test_nowarning_on_vector_deref() {
		simd_float2 x = {0, 1};
		return x[1]; // no-warning
		}