Page MenuHomePhabricator

[AMDGPU] Add default ISA version targets
ClosedPublic

Authored by rampitec on Mar 6 2018, 10:14 AM.

Details

Summary

In case if -mattr used to modify feature set bits in llvm-mc call
getIsaVersion can fail to identify specific ISA due to test mismatch.
Adding default fallback tests which will always correctly report at
least major version.

Diff Detail

Repository
rL LLVM

Event Timeline

rampitec created this revision.Mar 6 2018, 10:14 AM
kzhuravl accepted this revision.Mar 6 2018, 10:17 AM

LGTM.

This revision is now accepted and ready to land.Mar 6 2018, 10:17 AM
This revision was automatically updated to reflect the committed changes.

It seems that -mattr corrupts the design. What is the purpose of this option?