[lldb] Fix "requires global constructor" warning in g_range_specifiers

[labath]

source/Breakpoint/BreakpointID.cpp

49

You can probably make this static constexpr llvm::StringLiteral and avoid constructors altogether..

[davide]

LGTM with Pavel's suggestion implemented.

[labath]

BTW, to appease older versions of gcc you will need to write the initializer as = {{"-"}, {"to"}, ...} (i.e. add extra {} around the strings).

source/Breakpoint/BreakpointID.cpp

 using namespace lldb;
 using namespace lldb_private;
 
 BreakpointID::BreakpointID(break_id_t bp_id, break_id_t loc_id)
     : m_break_id(bp_id), m_location_id(loc_id) {}
 
 BreakpointID::~BreakpointID() = default;
 
-static llvm::StringRef g_range_specifiers[] = {"-", "to", "To", "TO"};
-
 // Tells whether or not STR is valid to use between two strings representing
 // breakpoint IDs, to
 // indicate a range of breakpoint IDs.  This is broken out into a separate
 // function so that we can
 // easily change or add to the format for specifying ID ranges at a later date.
 
 bool BreakpointID::IsRangeIdentifier(llvm::StringRef str) {
-  for (auto spec : g_range_specifiers) {
+  for (auto spec : GetRangeSpecifiers()) {
     if (spec == str)
       return true;
   }
 
   return false;
 }
 
 bool BreakpointID::IsValidIDExpression(llvm::StringRef str) {
   return BreakpointID::ParseCanonicalReference(str).hasValue();
 }
 
 llvm::ArrayRef<llvm::StringRef> BreakpointID::GetRangeSpecifiers() {
+  static llvm::StringRef g_range_specifiers[] = {"-", "to", "To", "TO"};
   return llvm::makeArrayRef(g_range_specifiers);
 }
 
 void BreakpointID::GetDescription(Stream *s, lldb::DescriptionLevel level) {
   if (level == eDescriptionLevelVerbose)
     s->Printf("%p BreakpointID:", static_cast<void *>(this));
 
   if (m_break_id == LLDB_INVALID_BREAK_ID)