This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Avoid cast ExprType to wasm::ValType
ClosedPublic

Authored by sbc100 on Mar 2 2018, 11:38 AM.

Details

Summary

This cast cast causing invalid signatures to be written for libcall functions.

Add an MC test which includes a call to builtin memcpy.

Diff Detail

Event Timeline

sbc100 created this revision.Mar 2 2018, 11:38 AM
sbc100 updated this revision to Diff 136828.Mar 2 2018, 12:26 PM
  • add test
sbc100 edited the summary of this revision. (Show Details)Mar 2 2018, 12:27 PM
aheejin accepted this revision.Mar 2 2018, 12:50 PM

Lgtm. Would we need enum class ValType : unsigned here as well?

This revision is now accepted and ready to land.Mar 2 2018, 12:50 PM
This revision was automatically updated to reflect the committed changes.