Page MenuHomePhabricator

[WebAssembly] Validate sections: order, and presence of required CODE
Needs ReviewPublic

Authored by ncw on Mar 2 2018, 9:08 AM.

Details

Reviewers
sbc100
sunfish
Summary

No test changes.


Split out of D43940 as requested - fixing tests is independent of the validation

Diff Detail

Event Timeline

ncw created this revision.Mar 2 2018, 9:08 AM
ncw added a comment.Mar 6 2018, 6:41 AM

This is stalled, until we agree on whether to actually check the order of the sections, or break it down into logic to check less generally that certain sections come after others; and secondly whether the order of all the sections even should be specified.

I've raised a GitHub issue to gather further feedback: https://github.com/WebAssembly/tool-conventions/issues/45

D54924, which tries to check similar things, has been landed. Let me know if you have any more suggestions.

sbc100 resigned from this revision.Mar 4 2019, 10:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 4 2019, 10:45 AM
Herald added a subscriber: sbc100. · View Herald Transcript
sunfish resigned from this revision.May 28 2019, 11:53 AM
aheejin added a comment.EditedMay 28 2019, 6:10 PM

Also more related patches: D58312