Page MenuHomePhabricator

Fixed spelling mistake in comments of LLVM Analysis passes
ClosedPublic

Authored by reshabh on Feb 28 2018, 12:50 AM.

Diff Detail

Event Timeline

reshabh created this revision.Feb 28 2018, 12:50 AM
reshabh retitled this revision from Fixed a spelling mistake in comment to Fixed spelling mistake in comments of LLVM Analysis passes.Feb 28 2018, 1:34 AM
reshabh edited the summary of this revision. (Show Details)
reshabh updated this revision to Diff 136250.Feb 28 2018, 1:40 AM

Fixed more spellings

JDevlieghere accepted this revision.Feb 28 2018, 1:56 AM
JDevlieghere added a subscriber: JDevlieghere.

Thanks Reshabh! Let us know if you need someone to commit this for you.

As a tip for next time, please always upload a full context diff (usually you can simply pass -U999999 to whatever tool you use to make a diff).

lib/Analysis/ValueTracking.cpp
3011

Since you're touching these lines anyway, it might be nice to reflow the comment.

This revision is now accepted and ready to land.Feb 28 2018, 1:56 AM

You beat me to it Jonas :)

Thanks for fixing those, LGTM.

Also, please add llvm-commits to the subscribers when creating reviews.

Thanks Reshabh! Let us know if you need someone to commit this for you.

As a tip for next time, please always upload a full context diff (usually you can simply pass -U999999 to whatever tool you use to make a diff).

Surely I'll take care of that from next time .

reshabh updated this revision to Diff 136256.Feb 28 2018, 2:35 AM

Fixed the comment flow at /llvm/lib/Analysis/ValueTracking.cpp

reshabh marked an inline comment as done.Feb 28 2018, 2:36 AM
vsk accepted this revision.Feb 28 2018, 11:10 AM

Thanks Reshabh!

(Reshabh is interesting in working on llvm for GSoC. As he's new to llvm, I'll go ahead and commit this for him.)

This revision was automatically updated to reflect the committed changes.