[ELF] - Check that output sections fit in address space.

[grimar]

Summary

I suggest to add checks to test that we do not produce
output where VA of sections overruns available address space.

[jhenderson]

Seems reasonable to me. A few nit comments though.

ELF/Writer.cpp

2066

addresses -> address

2071–2072

This comment looks like it's wrapped early?

2083–2084

Ditto comment wrapping. Also "Any" -> "any".

[grimar]

• Addressed comments. Thanks, James !

[grimar]

Do we want it?

[• espindola]

LGTM with nits.

ELF/Writer.cpp

2075

This is templated on ELFT, may as well use it.

It might be cleaner to write this as one check
(OS->Addr + OS->Size < OS->Addr) || (!ELF::Is64Bits && OS->Addr + OS->Size > UINT32_MAX)

[ruiu]

ELF/Writer.cpp

2071

You should have changed the name of this function because it does more than checking section overlaps.

[grimar]

ELF/Writer.cpp

2071

I renamed it to checkSections, it matches the command line option name. Does it sound fine?

ELF/Writer.cpp

if (B.Offset < A.Offset + A.Sec->Size)
       errorOrWarn(
           "section " + A.Sec->Name + " " + Name + " range overlaps with " +
           B.Sec->Name + "\n>>> " + A.Sec->Name + " range is " +
           rangeToString(A.Offset, A.Sec->Size) + "\n>>> " + B.Sec->Name +
           " range is " + rangeToString(B.Offset, B.Sec->Size));
   }
 }
 
-// Check for overlapping sections
+// Check for overlapping sections and address overflows.
 //
 // In this function we check that none of the output sections have overlapping
 // file offsets. For SHF_ALLOC sections we also check that the load address
 // ranges and the virtual address ranges don't overlap
 template <class ELFT> void Writer<ELFT>::checkSectionOverlap() {
-  // First check for overlapping file offsets. In this case we need to skip
-  // any section marked as SHT_NOBITS. These sections don't actually occupy
-  // space in the file so Sec->Offset + Sec->Size can overlap with others.
-  // If --oformat binary is specified only add SHF_ALLOC sections are added to
-  // the output file so we skip any non-allocated sections in that case.
+  // First, check that section's VAs fit in available address space for target.
+  for (OutputSection *OS : OutputSections)
+    if ((OS->Addr + OS->Size < OS->Addr) ||
+        (!ELFT::Is64Bits && OS->Addr + OS->Size > UINT32_MAX))
+      errorOrWarn("section " + OS->Name + " at 0x" + utohexstr(OS->Addr) +
+                  " of size 0x" + utohexstr(OS->Size) +
+                  " exceeds available address space");
+
+  // Check for overlapping file offsets. In this case we need to skip any
+  // section marked as SHT_NOBITS. These sections don't actually occupy space in
+  // the file so Sec->Offset + Sec->Size can overlap with others. If --oformat
+  // binary is specified only add SHF_ALLOC sections are added to the output
+  // file so we skip any non-allocated sections in that case.
   std::vector<SectionOffset> FileOffs;
   for (OutputSection *Sec : OutputSections)
     if (0 < Sec->Size && Sec->Type != SHT_NOBITS &&
         (!Config->OFormatBinary || (Sec->Flags & SHF_ALLOC)))
       FileOffs.push_back({Sec, Sec->Offset});
   checkOverlap("file", FileOffs);
 
   // When linking with -r there is no need to check for overlapping virtual/load

test/ELF/linkerscript/i386-sections-max-va-overflow.s

+# REQUIRES: x86
+# RUN: llvm-mc -filetype=obj -triple=i386-pc-linux %s -o %t.o
+
+# RUN: echo "SECTIONS { . = 0xfffffff1;" > %t.script
+# RUN: echo "           .bar : { *(.bar*) } }" >> %t.script
+# RUN: not ld.lld -o %t.so --script %t.script %t.o 2>&1 | FileCheck %s -check-prefix=ERR
+
+## .bar section has data in [0xfffffff1, 0xfffffff1 + 0x10] == [0xffffff1, 0x1]. 
+## Check we can catch this overflow.
+# ERR: error: section .bar at 0xFFFFFFF1 of size 0x10 exceeds available address space
+
+.section .bar,"ax",@progbits
+.zero 0x10

test/ELF/linkerscript/output-too-large.s

 # REQUIRES: x86
 # RUN: llvm-mc -filetype=obj -triple=i686-unknown-linux %s -o %t.o
 # RUN: echo "SECTIONS { .text : { . = 0xffffffff; *(.text*); } }" > %t.script
-# RUN: not ld.lld --script %t.script %t.o -o %t 2>&1 | FileCheck %s
+# RUN: not ld.lld --no-check-sections --script %t.script %t.o -o %t 2>&1 | FileCheck %s
 # CHECK: error: output file too large
 
 .global _start
 _start:
   nop

test/ELF/linkerscript/sections-max-va-overflow.s

+# REQUIRES: x86
+# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o
+
+# RUN: echo "SECTIONS { . = 0xfffffffffffffff1;" > %t.script
+# RUN: echo "           .bar : { *(.bar*) } }" >> %t.script
+# RUN: not ld.lld -o %t.so --script %t.script %t.o 2>&1 | FileCheck %s -check-prefix=ERR
+
+## .bar section has data in [0xfffffffffffffff1, 0xfffffffffffffff1 + 0x10] ==
+## [0xfffffffffffffff1, 0x1]. Check we can catch this overflow.
+# ERR: error: section .bar at 0xFFFFFFFFFFFFFFF1 of size 0x10 exceeds available address space
+
+.section .bar,"ax",@progbits
+.zero 0x10