This is an archive of the discontinued LLVM Phabricator instance.

Differential D43775

add UUID to the acronyms list of objc property name checks
ClosedPublic

Authored by Wizard on Feb 26 2018, 12:15 PM.

Details

Reviewers
benhamilton
hokein
Commits
rGee6303921b06: add UUID to the acronyms list of objc property name checks
rL326222: add UUID to the acronyms list of objc property name checks
rCTE326222: add UUID to the acronyms list of objc property name checks

Diff Detail

Event Timeline

Wizard created this revision.Feb 26 2018, 12:15 PM
Herald added subscribers: cfe-commits, klimek. · View Herald TranscriptFeb 26 2018, 12:15 PM
Wizard added reviewers: benhamilton, hokein.Feb 26 2018, 12:16 PM
Harbormaster completed remote builds in B15441: Diff 135946.Feb 26 2018, 12:17 PM
hokein added a comment.Feb 27 2018, 2:54 AM

The change seems good to me. I'd leave the approval to @benhamilton since he has more context on objc.

benhamilton accepted this revision.Feb 27 2018, 7:33 AM
benhamilton added inline comments.
clang-tidy/objc/PropertyDeclarationCheck.cpp
52–53

Might as well also add GUID.

This revision is now accepted and ready to land.Feb 27 2018, 7:33 AM
Wizard updated this revision to Diff 136100.Feb 27 2018, 10:35 AM

resolve comment

Wizard marked an inline comment as done.Feb 27 2018, 10:35 AM
Harbormaster completed remote builds in B15481: Diff 136100.Feb 27 2018, 10:36 AM
benhamilton added a comment.Feb 27 2018, 10:39 AM

LGTM.

Closed by commit rCTE326222: add UUID to the acronyms list of objc property name checks (authored by Wizard). · Explain WhyFeb 27 2018, 10:39 AM
Closed by commit rL326222: add UUID to the acronyms list of objc property name checks (authored by Wizard). · Explain Why
This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptFeb 27 2018, 10:39 AM

Revision Contents

PathSize
clang-tidy/
objc/
2 lines

Diff 136102

clang-tidy/objc/PropertyDeclarationCheck.cpp

Show First 20 Lines • Show All 43 Lines • ▼ Show 20 Linesconstexpr llvm::StringLiteral DefaultSpecialAcronyms[] = {
"ARGB", "ARGB",
"ASCII", "ASCII",
"BGRA", "BGRA",
"CMYK", "CMYK",
"DNS", "DNS",
"FPS", "FPS",
"FTP", "FTP",
"GIF", "GIF",
"GPS", "GPS",
"GUID",
benhamiltonUnsubmitted
Done
ReplyInline Actions

Might as well also add GUID.

benhamilton: Might as well also add GUID.
"HD", "HD",
"HDR", "HDR",
"HTML", "HTML",
"HTTP", "HTTP",
"HTTPS", "HTTPS",
"HUD", "HUD",
"ID", "ID",
"JPG", "JPG",
Show All 21 Linesconstexpr llvm::StringLiteral DefaultSpecialAcronyms[] = {
"SDK", "SDK",
"SSO", "SSO",
"TCP", "TCP",
"TIFF", "TIFF",
"TTS", "TTS",
"UI", "UI",
"URI", "URI",
"URL", "URL",
"UUID",
"VC", "VC",
"VOIP", "VOIP",
"VPN", "VPN",
"VR", "VR",
"WAN", "WAN",
"XML", "XML",
}; };
▲ Show 20 Lines • Show All 132 Lines • Show Last 20 Lines