This is an archive of the discontinued LLVM Phabricator instance.

add UUID to the acronyms list of objc property name checks
ClosedPublic

Authored by Wizard on Feb 26 2018, 12:15 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

Wizard created this revision.Feb 26 2018, 12:15 PM

The change seems good to me. I'd leave the approval to @benhamilton since he has more context on objc.

benhamilton accepted this revision.Feb 27 2018, 7:33 AM
benhamilton added inline comments.
clang-tidy/objc/PropertyDeclarationCheck.cpp
52 ↗(On Diff #135946)

Might as well also add GUID.

This revision is now accepted and ready to land.Feb 27 2018, 7:33 AM
Wizard updated this revision to Diff 136100.Feb 27 2018, 10:35 AM

resolve comment

Wizard marked an inline comment as done.Feb 27 2018, 10:35 AM
This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.