This is an archive of the discontinued LLVM Phabricator instance.

Differential D43721

[WebAssembly] Use StringRef instead of `const char *`.
ClosedPublic

Authored by ruiu on Feb 23 2018, 9:22 PM.

Details

Reviewers
sbc100
Commits
rG37254065ddd3: [WebAssembly] Use StringRef instead of `const char *`.
rLLD326269: [WebAssembly] Use StringRef instead of `const char *`.
rL326269: [WebAssembly] Use StringRef instead of `const char *`.
Summary

[WebAssembly] Use StringRef instead of const char *.

Diff Detail

Event Timeline

ruiu created this revision.Feb 23 2018, 9:22 PM
Herald added subscribers: sunfish, aheejin, jgravelle-google and 2 others. · View Herald TranscriptFeb 23 2018, 9:23 PM
Harbormaster completed remote builds in B15399: Diff 135778.Feb 23 2018, 9:24 PM
sbc100 accepted this revision.Feb 27 2018, 12:48 PM
This revision is now accepted and ready to land.Feb 27 2018, 12:48 PM
Closed by commit rL326269: [WebAssembly] Use StringRef instead of `const char *`. (authored by ruiu). · Explain WhyFeb 27 2018, 4:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lld/
wasm/
20 lines

Diff 135778

lld/wasm/Writer.cpp

Show First 20 Lines • Show All 345 Lines • ▼ Show 20 Lines
// Create relocations sections in the final output. // Create relocations sections in the final output.
// These are only created when relocatable output is requested. // These are only created when relocatable output is requested.
void Writer::createRelocSections() { void Writer::createRelocSections() {
log("createRelocSections"); log("createRelocSections");
// Don't use iterator here since we are adding to OutputSection // Don't use iterator here since we are adding to OutputSection
size_t OrigSize = OutputSections.size(); size_t OrigSize = OutputSections.size();
for (size_t i = 0; i < OrigSize; i++) { for (size_t i = 0; i < OrigSize; i++) {
OutputSection *S = OutputSections[i]; OutputSection *OSec = OutputSections[i];
const char *name; uint32_t Count = OSec->numRelocations();
uint32_t Count = S->numRelocations();
if (!Count) if (!Count)
continue; continue;
if (S->Type == WASM_SEC_DATA) StringRef Name;
name = "reloc.DATA"; if (OSec->Type == WASM_SEC_DATA)
else if (S->Type == WASM_SEC_CODE) Name = "reloc.DATA";
name = "reloc.CODE"; else if (OSec->Type == WASM_SEC_CODE)
Name = "reloc.CODE";
else else
llvm_unreachable("relocations only supported for code and data"); llvm_unreachable("relocations only supported for code and data");
SyntheticSection *Section = createSyntheticSection(WASM_SEC_CUSTOM, name); SyntheticSection *Section = createSyntheticSection(WASM_SEC_CUSTOM, Name);
raw_ostream &OS = Section->getStream(); raw_ostream &OS = Section->getStream();
writeUleb128(OS, S->Type, "reloc section"); writeUleb128(OS, OSec->Type, "reloc section");
writeUleb128(OS, Count, "reloc count"); writeUleb128(OS, Count, "reloc count");
S->writeRelocations(OS); OSec->writeRelocations(OS);
} }
} }
static uint32_t getWasmFlags(const Symbol *Sym) { static uint32_t getWasmFlags(const Symbol *Sym) {
uint32_t Flags = 0; uint32_t Flags = 0;
if (Sym->isLocal()) if (Sym->isLocal())
Flags |= WASM_SYMBOL_BINDING_LOCAL; Flags |= WASM_SYMBOL_BINDING_LOCAL;
if (Sym->isWeak()) if (Sym->isWeak())
▲ Show 20 Lines • Show All 632 Lines • Show Last 20 Lines