This is an archive of the discontinued LLVM Phabricator instance.

Add a sanity check for inline tests
ClosedPublic

Authored by aprantl on Feb 23 2018, 1:59 PM.

Details

Summary

When writing an inline test, there is no way to make sure that any of the inline commands are actually executed, so this patch adds a sanity check that at least one breakpoint was hit. This avoids a test with no breakpoints being hit passing.

Diff Detail

Event Timeline

aprantl created this revision.Feb 23 2018, 1:59 PM
labath accepted this revision.Feb 23 2018, 2:06 PM

Looks good. One extra possible check would be to make sure that at the exit of the loop, the inferior is in an expected state (eStateExited with result 0?)

This revision is now accepted and ready to land.Feb 23 2018, 2:06 PM
This revision was automatically updated to reflect the committed changes.