With this there are still some GVs where we don't set dso_local because setGVProperties is never called. I intend to fix that in followup commits. This is just the bare minimum to teach shouldAssumeDSOLocal what it should do for COFF.
Diff Detail
Diff Detail
Event Timeline
Comment Actions
Some inline comments - I think this looks ok in general, but I'm curious about the answers to the questions/documentation bits inline.
Thanks!
lib/CodeGen/CGDecl.cpp | ||
---|---|---|
257 | If positioning is important here we should probably document it. | |
lib/CodeGen/CodeGenModule.cpp | ||
726 | "firmware" | |
733 | This seems to need an update? | |
lib/CodeGen/ItaniumCXXABI.cpp | ||
1650 | Ditto with the moving comment from above. |
lib/CodeGen/CodeGenModule.h | ||
---|---|---|
728 ↗ | (On Diff #135547) | Agreed? Maybe? Should the rest of the properties from above each call be set in this function? Since you've got the decl it might be best to get as many of them in one place as possible? |
If positioning is important here we should probably document it.