This is an archive of the discontinued LLVM Phabricator instance.

Differential D43429

[clangd] Add missing library (clangLex) in a few places
AbandonedPublic

Authored by malaperle on Feb 16 2018, 8:57 PM.

Details

Reviewers
ioeric
Summary

Fixes undefined reference to 'clang::Preprocessor::addCommentHandler'
when building with -DBUILD_SHARED_LIBS.

Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Diff Detail

Event Timeline

malaperle created this revision.Feb 16 2018, 8:57 PM
Herald added subscribers: cfe-commits, ioeric, jkorous-apple and 3 others. · View Herald TranscriptFeb 16 2018, 8:57 PM
Harbormaster completed remote builds in B15123: Diff 134787.Feb 16 2018, 8:59 PM
malaperle added a reviewer: ioeric.Feb 16 2018, 9:01 PM
ioeric accepted this revision.Feb 17 2018, 11:55 AM

lg. Thanks!

This revision is now accepted and ready to land.Feb 17 2018, 11:55 AM
ioeric mentioned this in D43437: [clangd] Fix link failures for Preprocessor::addCommentHandler.Feb 18 2018, 2:37 AM
malaperle abandoned this revision.Feb 18 2018, 9:21 PM

Already landed in another commit.

Revision Contents

PathSize
clangd/
global-symbol-builder/
1 line
unittests/
clangd/
1 line

Diff 134787

clangd/global-symbol-builder/CMakeLists.txt

Show All 9 Lines
target_link_libraries(global-symbol-builder target_link_libraries(global-symbol-builder
PRIVATE PRIVATE
clangAST clangAST
clangIndex clangIndex
clangDaemon clangDaemon
clangBasic clangBasic
clangFrontend clangFrontend
clangLex
clangTooling clangTooling
) )

unittests/clangd/CMakeLists.txt

Show All 32 Lines
target_link_libraries(ClangdTests target_link_libraries(ClangdTests
PRIVATE PRIVATE
clangBasic clangBasic
clangDaemon clangDaemon
clangFormat clangFormat
clangFrontend clangFrontend
clangIndex clangIndex
clangLex
clangSema clangSema
clangTooling clangTooling
clangToolingCore clangToolingCore
LLVMSupport LLVMSupport
) )