This is an archive of the discontinued LLVM Phabricator instance.

Differential D43418

[X86] Add 'sahf' to getHostCPUFeatures so -march=native will pick it up correctly.
ClosedPublic

Authored by craig.topper on Feb 16 2018, 3:36 PM.

Details

Reviewers
RKSimon
echristo
dim
spatel
Commits
rG8d02be3bf374: [X86] Add 'sahf' to getHostCPUFeatures so -march=native will pick it up…
rL325439: [X86] Add 'sahf' to getHostCPUFeatures so -march=native will pick it up…
Summary

We probably mostly get this right due to family/model/stepping mapping to CPU names. But we should detect it explicitly.

Diff Detail

Event Timeline

craig.topper created this revision.Feb 16 2018, 3:36 PM
dim accepted this revision.Feb 17 2018, 3:52 AM

LGTM.

This revision is now accepted and ready to land.Feb 17 2018, 3:52 AM
Closed by commit rL325439: [X86] Add 'sahf' to getHostCPUFeatures so -march=native will pick it up… (authored by ctopper). · Explain WhyFeb 17 2018, 8:55 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Support/
1 line

Diff 134750

lib/Support/Host.cpp

Show First 20 Lines • Show All 1,200 Lines • ▼ Show 20 Linesbool sys::getHostCPUFeatures(StringMap<bool> &Features) {
Features["xsave"] = ((ECX >> 26) & 1) && HasAVXSave; Features["xsave"] = ((ECX >> 26) & 1) && HasAVXSave;
Features["f16c"] = ((ECX >> 29) & 1) && HasAVXSave; Features["f16c"] = ((ECX >> 29) & 1) && HasAVXSave;
unsigned MaxExtLevel; unsigned MaxExtLevel;
getX86CpuIDAndInfo(0x80000000, &MaxExtLevel, &EBX, &ECX, &EDX); getX86CpuIDAndInfo(0x80000000, &MaxExtLevel, &EBX, &ECX, &EDX);
bool HasExtLeaf1 = MaxExtLevel >= 0x80000001 && bool HasExtLeaf1 = MaxExtLevel >= 0x80000001 &&
!getX86CpuIDAndInfo(0x80000001, &EAX, &EBX, &ECX, &EDX); !getX86CpuIDAndInfo(0x80000001, &EAX, &EBX, &ECX, &EDX);
Features["sahf"] = HasExtLeaf1 && ((ECX >> 0) & 1);
Features["lzcnt"] = HasExtLeaf1 && ((ECX >> 5) & 1); Features["lzcnt"] = HasExtLeaf1 && ((ECX >> 5) & 1);
Features["sse4a"] = HasExtLeaf1 && ((ECX >> 6) & 1); Features["sse4a"] = HasExtLeaf1 && ((ECX >> 6) & 1);
Features["prfchw"] = HasExtLeaf1 && ((ECX >> 8) & 1); Features["prfchw"] = HasExtLeaf1 && ((ECX >> 8) & 1);
Features["xop"] = HasExtLeaf1 && ((ECX >> 11) & 1) && HasAVXSave; Features["xop"] = HasExtLeaf1 && ((ECX >> 11) & 1) && HasAVXSave;
Features["lwp"] = HasExtLeaf1 && ((ECX >> 15) & 1); Features["lwp"] = HasExtLeaf1 && ((ECX >> 15) & 1);
Features["fma4"] = HasExtLeaf1 && ((ECX >> 16) & 1) && HasAVXSave; Features["fma4"] = HasExtLeaf1 && ((ECX >> 16) & 1) && HasAVXSave;
Features["tbm"] = HasExtLeaf1 && ((ECX >> 21) & 1); Features["tbm"] = HasExtLeaf1 && ((ECX >> 21) & 1);
Features["mwaitx"] = HasExtLeaf1 && ((ECX >> 29) & 1); Features["mwaitx"] = HasExtLeaf1 && ((ECX >> 29) & 1);
▲ Show 20 Lines • Show All 136 Lines • Show Last 20 Lines