[WebAssembly] Remove unneeded Chunk::getFileName() method. NFC.

[ruiu]

LGTM

But I believe a better way of doing this kind of stuff is to define toString(InputChunk *). toString() function is a common interface to stringize objects to create debug messages.

[sbc100]

In D43405#1010999, @ruiu wrote:

LGTM

But I believe a better way of doing this kind of stuff is to define toString(InputChunk *). toString() function is a common interface to stringize objects to create debug messages.

But in this case the only user actually wants the filename on its own.. not the string description of the chunk. (ELF does basically exactly the same thing here BTW)

[ruiu]

Good observation, but I think we should use toString() in ELF too. toString() is there for you so that you don't need to construct a string like this, and doing this is error-prone. In this case, if file foo.o is in bar.a, toString generates something like

bar.a(foo.o):(.text)

while this string construction generates a string like

'.text' in file 'foo.o'

which isn't very helpful if you don't know which file foo.o is in.

lld/trunk/wasm/InputChunks.h

public:
 
   void setOutputOffset(uint32_t Offset) {
     OutputOffset = Offset;
     calcRelocations();
   }
 
   uint32_t getOutputOffset() const { return OutputOffset; }
   ArrayRef<WasmRelocation> getRelocations() const { return Relocations; }
-  StringRef getFileName() const { return File->getName(); }
 
   virtual StringRef getComdat() const = 0;
   virtual StringRef getName() const = 0;
 
   std::vector<OutputRelocation> OutRelocations;
   ObjFile *File;
 
   // Signals that the section is part of the output.  The garbage collector,

lld/trunk/wasm/MarkLive.cpp

void lld::wasm::markLive() {
   while (!Q.empty())
     EnqueueSuccessors(*Q.pop_back_val());
 
   // Report garbage-collected sections.
   if (Config->PrintGcSections) {
     auto CheckChunk = [](const InputChunk *C) {
       if (!C->Live)
         message("removing unused section '" + C->getName() + "' in file '" +
-                C->getFileName() + "'");
+                C->File->getName() + "'");
     };
 
     for (const ObjFile *Obj : Symtab->ObjectFiles) {
       for (InputChunk *C : Obj->Functions)
         CheckChunk(C);
       for (InputChunk *C : Obj->Segments)
         CheckChunk(C);
     }
   }
 }