This is an archive of the discontinued LLVM Phabricator instance.

ELF: Stop collecting a list of symbols in ArchiveFile.
ClosedPublic

Authored by pcc on Feb 15 2018, 9:05 PM.

Details

Summary

There seems to be no reason to collect this list of symbols.

Also fix a bug where --exclude-libs would apply to all symbols that
appear in an archive's symbol table, even if the relevant archive
member was not added to the link.

Diff Detail

Repository
rLLD LLVM Linker

Event Timeline

pcc created this revision.Feb 15 2018, 9:05 PM
ruiu accepted this revision.Feb 15 2018, 9:08 PM

LGTM

This revision is now accepted and ready to land.Feb 15 2018, 9:08 PM
pcc planned changes to this revision.Feb 15 2018, 9:13 PM
pcc added inline comments.
lld/ELF/Driver.cpp
998 ↗(On Diff #134553)

Wait, this isn't quite right yet, I think we need to check Sym->File == File here now.

pcc updated this revision to Diff 134555.Feb 15 2018, 9:29 PM

Bug fix

This revision is now accepted and ready to land.Feb 15 2018, 9:29 PM
pcc updated this revision to Diff 134557.Feb 15 2018, 9:30 PM
  • Remove unused file
Harbormaster completed remote builds in B15055: Diff 134557.
This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.