This is an archive of the discontinued LLVM Phabricator instance.

[TSan] Fix static TLS boundaries calculations in __tls_get_addr interceptor.
ClosedPublic

Authored by alekseyshl on Feb 14 2018, 4:29 PM.

Reviewers

Commits

Summary

DTLS_on_tls_get_addr expects (tls_addr + tls_size) as the last
parameter, static_tls_end.

Repository

rCRT Compiler Runtime

Build Status

Buildable 15001
Build 15001: arc lint + arc unit

This revision is now accepted and ready to land.Feb 14 2018, 10:40 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

lib/

tsan/

rtl/

3 lines

	Show First 20 Lines • Show All 2,528 Lines • ▼ Show 20 Lines
	// https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58066			// https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58066
	// So the interceptor must work with mis-aligned stack, in particular, does not			// So the interceptor must work with mis-aligned stack, in particular, does not
	// execute MOVDQA with stack addresses.			// execute MOVDQA with stack addresses.
	TSAN_INTERCEPTOR(void , __tls_get_addr, void arg) {			TSAN_INTERCEPTOR(void , __tls_get_addr, void arg) {
	void *res = REAL(__tls_get_addr)(arg);			void *res = REAL(__tls_get_addr)(arg);
	ThreadState *thr = cur_thread();			ThreadState *thr = cur_thread();
	if (!thr)			if (!thr)
	return res;			return res;
	DTLS::DTV *dtv = DTLS_on_tls_get_addr(arg, res, thr->tls_addr, thr->tls_size);			DTLS::DTV *dtv = DTLS_on_tls_get_addr(arg, res, thr->tls_addr,
				thr->tls_addr + thr->tls_size);
	if (!dtv)			if (!dtv)
	return res;			return res;
	// New DTLS block has been allocated.			// New DTLS block has been allocated.
	MemoryResetRange(thr, 0, dtv->beg, dtv->size);			MemoryResetRange(thr, 0, dtv->beg, dtv->size);
	return res;			return res;
	}			}
	#endif			#endif

	▲ Show 20 Lines • Show All 281 Lines • Show Last 20 Lines