This is an archive of the discontinued LLVM Phabricator instance.

[ARM] f16 vcmp fixes
ClosedPublic

Authored by SjoerdMeijer on Feb 14 2018, 7:33 AM.

Details

Summary

This adds a VCMPEZH match rule and fixes the f16 VCMP test cases.

Diff Detail

Event Timeline

SjoerdMeijer created this revision.Feb 14 2018, 7:33 AM
samparker added inline comments.Feb 14 2018, 8:05 AM
test/CodeGen/ARM/fp16-instructions.ll
126

Should this be testing CHECK-HARDFP-FULLFP16-NOT instead?

132

Do we need a VCMP_IMM test too? Or am I missing something?

olista01 added inline comments.Feb 14 2018, 8:52 AM
lib/Target/ARM/ARMInstrVFP.td
627

Could we also add the pattern for VCMPZH?

Thanks for reviewing, comments addressed.

samparker accepted this revision.Feb 15 2018, 2:27 AM

LGTM, cheers.

This revision is now accepted and ready to land.Feb 15 2018, 2:27 AM
This revision was automatically updated to reflect the committed changes.