This is an archive of the discontinued LLVM Phabricator instance.

[DeadStoreElimination] Salvage debug info from dead insts
ClosedPublic

Authored by vsk on Feb 12 2018, 9:01 PM.

Details

Summary

According to llvm-dwarfdump --statistics this salvages 43 additional
unique source variables in a stage2 build of clang. It increases the
size of the .debug_loc section by 0.002% (or 2864 bytes).

Diff Detail

Event Timeline

vsk created this revision.Feb 12 2018, 9:01 PM
davide accepted this revision.Feb 13 2018, 7:09 AM

This is fine, but haven't looked whether DSE has other places where it removes instructions.

This revision is now accepted and ready to land.Feb 13 2018, 7:09 AM
vsk added a comment.Feb 13 2018, 10:10 AM

This is fine, but haven't looked whether DSE has other places where it removes instructions.

Thanks. This is the only site which calls eraseFromParent(), so we should be set.

This revision was automatically updated to reflect the committed changes.