This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Update ADT/TripleTest.cpp now that default file format has changed
ClosedPublic

Authored by sbc100 on Feb 12 2018, 3:44 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

sbc100 created this revision.Feb 12 2018, 3:44 PM
dschuff accepted this revision.Feb 12 2018, 3:45 PM
This revision is now accepted and ready to land.Feb 12 2018, 3:45 PM
sunfish accepted this revision.Feb 12 2018, 3:49 PM

The new tests look good, but it'd be good to keep testing "wasm32-unknown-unknown-wasm" and "wasm64-unknown-unknown-wasm" here too.

This revision was automatically updated to reflect the committed changes.

The new tests look good, but it'd be good to keep testing "wasm32-unknown-unknown-wasm" and "wasm64-unknown-unknown-wasm" here too.

Please restore the "-wasm" forms of these tests too.

I've now re-added these tests myself, in r325273.

Sorry about that. You are right to test all the cases.