Page MenuHomePhabricator

Add CMAKE_CFG_INTDIR as part of the include path for the default test compiler.

Authored by asmith on Feb 6 2018, 3:56 PM.



This is a small change towards running the LLDB unit tests on Windows (still WIP).

Builds that use make do not point to specific configurations. However, builds with multiple configurations such as Visual Studio on Windows need the configuration (release/debug/etc) as part of the path so the binaries produced by clang are placed in the correct directory for the configuration.

Diff Detail

Event Timeline

asmith created this revision.Feb 6 2018, 3:56 PM
asmith edited the summary of this revision. (Show Details)Feb 6 2018, 3:56 PM
labath accepted this revision.Feb 7 2018, 2:20 AM
labath added a subscriber: labath.

looks good.

Technically, this is a property of the cmake generator (VS projects), and not the host system (windows), but I get what you mean..

This revision is now accepted and ready to land.Feb 7 2018, 2:20 AM
asmith edited the summary of this revision. (Show Details)Feb 7 2018, 1:06 PM

Thanks! Have updated the commit message to clarify.

asmith closed this revision.Feb 7 2018, 6:15 PM