This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] removed dead code handling rmw in memory legalizer
ClosedPublic

Authored by rampitec on Feb 6 2018, 10:50 AM.

Details

Summary

It was always using cmpxchg path and in rmw and cmpxchg instructions
are not distinguishable in the BE.

Diff Detail

Event Timeline

rampitec created this revision.Feb 6 2018, 10:50 AM
kzhuravl accepted this revision.Feb 6 2018, 11:02 AM

LGTM with minor nit.

lib/Target/AMDGPU/SIMemoryLegalizer.cpp
110

Move to previous line.

This revision is now accepted and ready to land.Feb 6 2018, 11:02 AM
rampitec updated this revision to Diff 133053.Feb 6 2018, 11:06 AM
rampitec marked an inline comment as done.

Comment formatting.

This revision was automatically updated to reflect the committed changes.