This is an archive of the discontinued LLVM Phabricator instance.

[asan] Make concurrent_overflow.cc less flaky
ClosedPublic

Authored by kubamracek on Feb 2 2018, 11:41 AM.

Reviewers

Commits

Summary

The "sleep(5)" sometimes times out on our bots, causing the test to fail. Let's use pthread_join.

This revision is now accepted and ready to land.Feb 2 2018, 11:45 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

test/

asan/

TestCases/

Posix/

7 lines

Show All 14 Lines	while (*counter)
;		;
buf[0] = buf[9];		buf[0] = buf[9];
return 0;		return 0;
}		}

int main(void) {		int main(void) {
const int n_threads = 8;		const int n_threads = 8;
int i, counter = n_threads;		int i, counter = n_threads;
pthread_t thread;		pthread_t thread[n_threads];

for (i = 0; i < n_threads; ++i)		for (i = 0; i < n_threads; ++i)
pthread_create(&thread, NULL, &start_routine, (void *)&counter);		pthread_create(&thread[i], NULL, &start_routine, (void *)&counter);
sleep(5);		for (i = 0; i < n_threads; ++i)
		pthread_join(thread[i], NULL);
return 0;		return 0;
}		}

// CHECK-NOT: nested bug		// CHECK-NOT: nested bug
// CHECK: ERROR: AddressSanitizer: stack-buffer-overflow on address		// CHECK: ERROR: AddressSanitizer: stack-buffer-overflow on address
// CHECK: SUMMARY: AddressSanitizer: stack-buffer-overflow		// CHECK: SUMMARY: AddressSanitizer: stack-buffer-overflow