Page MenuHomePhabricator

[OpenCL] Add test for atomic pointers.
Needs ReviewPublic

Authored by Fznamznon on Feb 2 2018, 7:21 AM.

Details

Reviewers
Anastasia

Diff Detail

Event Timeline

Fznamznon created this revision.Feb 2 2018, 7:21 AM

Sorry for delay... Does this test anything OpenCL specific? As far as I remember we don't have any changes to PointerType with an atomic pointee type.

Yes, we don't have anything OpenCL specific for atomic pointers.
But we have OpenCL specific in pointers and atomics separately and we have address spaces.
Why not to test all at once?

Yes, we don't have anything OpenCL specific for atomic pointers.
But we have OpenCL specific in pointers and atomics separately and we have address spaces.
Why not to test all at once?

We don't typically do integration testing in Clang to keep the runtime of tests within reasonable bounds. Even though this test is quite small I would say if it doesn't increase our code coverage (test a program path which is not tested yet) I wouldn't be so keen to add it. As for the pointer type implementation I don't think this test is testing any new behavior to what we already cover by C pointer tests. I don't remember any special rule in OpenCL wrt operations on either atomics or local pointers.