This is an archive of the discontinued LLVM Phabricator instance.

MIR PhysReg sigil change from '%' to '$'
ClosedPublic

Authored by plotfi on Jan 31 2018, 10:08 AM.

Details

Summary

This is the patch to change the sigil for MIR physical registers to using '$' so that we don't have name conflicts with named vregs that will be coming in the future,

Diff Detail

Repository
rL LLVM

Event Timeline

plotfi created this revision.Jan 31 2018, 10:08 AM
MatzeB accepted this revision.Jan 31 2018, 10:28 AM

Thanks for doing all the testcase fixup work!

LGTM with some nitpicks addressed:

  • Probably a good idea to include a link to the mailing list discussion in the commit message
lib/CodeGen/MIRParser/MILexer.cpp
413–434

You could split this into maybeLexPhysicalRegister() and maybeLexVirtualRegister(), given that there is no shared logic anymore between the two cases.

This revision is now accepted and ready to land.Jan 31 2018, 10:28 AM
thegameg accepted this revision.Jan 31 2018, 10:55 AM

Thanks!

I think MIRLangRef needs to be updated, but other than that, LGTM!

lib/CodeGen/MIRParser/MILexer.cpp
422

The plan is to turn this on at some point?

Hey @plotfi, could you update MIRLangRef with your changes please?

plotfi closed this revision.Apr 9 2018, 9:49 AM