[clang-format] Set ObjCBinPackProtocolList to Never for google style

[benhamilton]

Summary

This is split off from D42650, and sets ObjCBinPackProtocolList
to Never for the google style.

Depends On D42650

Test Plan: New tests added. make -j12 FormatTests && ./tools/clang/unittests/Format/FormatTests

[jolesiak]

lib/Format/Format.cpp

767

If I understand correctly this is meant to be ObjC-specific flag. I feel like this should be put in general config (next to GoogleStyle.ObjcSpaceAfterProperty and GoogleStyle.ObjCSpaceBeforeProtocolList; ~50 lines above).
To me putting it inside 'if' check means different value is used for ObjC than for other languages (what isn't the case here, as this flag shouldn't be used in formatting other languages code).

[benhamilton]

Move to general property section

[benhamilton]

lib/Format/Format.cpp

767

Done. It looked like all the modifications were alphabetized, so I moved it between GoogleStyle.AlwaysBreakTemplateDeclarations and GoogleStyle.ConstructorInitializerAllOnOneLineOrOnePerLine.

[benhamilton]

• BinPackObjCProtocolList -> ObjCBinPackProtocolList

[benhamilton]

lib/Format/Format.cpp

767

Actually, on second thought, I've just renamed it to ObjCBinPackProtocolList.

[benhamilton]

Fix comment.

[stephanemoore]

I believe that I have consensus from Google to be able to approve this. I sent out a last call for dissenting opinions. If I don't hear anything I plan on approving tomorrow.

[stephanemoore]

Pretty unanimous from the Google style arbitration side. Looks good to me.

lib/Format/Format.cpp

FormatStyle getGoogleStyle(FormatStyle::LanguageKind Language) {
   GoogleStyle.AlwaysBreakTemplateDeclarations = true;
   GoogleStyle.ConstructorInitializerAllOnOneLineOrOnePerLine = true;
   GoogleStyle.DerivePointerAlignment = true;
   GoogleStyle.IncludeCategories = {
       {"^<ext/.*\\.h>", 2}, {"^<.*\\.h>", 1}, {"^<.*", 2}, {".*", 3}};
   GoogleStyle.IncludeIsMainRegex = "([-_](test|unittest))?$";
   GoogleStyle.IndentCaseLabels = true;
   GoogleStyle.KeepEmptyLinesAtTheStartOfBlocks = false;
+  GoogleStyle.ObjCBinPackProtocolList = FormatStyle::BPS_Never;
   GoogleStyle.ObjCSpaceAfterProperty = false;
   GoogleStyle.ObjCSpaceBeforeProtocolList = true;
   GoogleStyle.PointerAlignment = FormatStyle::PAS_Left;
   GoogleStyle.RawStringFormats = {{
       FormatStyle::LK_TextProto,
       /*Delimiters=*/
       {
           "pb",
if (Language == FormatStyle::LK_Java) {
     GoogleStyle.JavaScriptQuotes = FormatStyle::JSQS_Single;
     GoogleStyle.JavaScriptWrapImports = false;
   } else if (Language == FormatStyle::LK_Proto) {
     GoogleStyle.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_None;
     GoogleStyle.SpacesInContainerLiterals = false;
     GoogleStyle.Cpp11BracedListStyle = false;
   } else if (Language == FormatStyle::LK_ObjC) {
     GoogleStyle.ColumnLimit = 100;
   }
 
   return GoogleStyle;
 }
 
 FormatStyle getChromiumStyle(FormatStyle::LanguageKind Language) {
   FormatStyle ChromiumStyle = getGoogleStyle(Language);
   if (Language == FormatStyle::LK_Java) {
     ChromiumStyle.AllowShortIfStatementsOnASingleLine = true;

unittests/Format/FormatTestObjC.cpp

verifyFormat("@interface Foo : NSObject <NSSomeDelegate> {\n"
                "+ (id)init;\n"
                "@end");
   verifyFormat("@interface Foo : Bar <Baz, Quux>\n"
                "+ (id)init;\n"
                "@end");
   verifyFormat("@interface Foo (HackStuff) <MyProtocol>\n"
                "+ (id)init;\n"
                "@end");
-  Style.BinPackParameters = false;
-  Style.ColumnLimit = 80;
-  verifyFormat("@interface aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa () <\n"
-               "    aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
-               "    aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
-               "    aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
-               "    aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa> {\n"
+  Style.ColumnLimit = 40;
+  // BinPackParameters should be true by default.
+  verifyFormat("void eeeeeeee(int eeeee, int eeeee,\n"
+               "              int eeeee, int eeeee);\n");
+  // ObjCBinPackProtocolList should be BPS_Never by default.
+  verifyFormat("@interface fffffffffffff () <\n"
+               "    fffffffffffff,\n"
+               "    fffffffffffff,\n"
+               "    fffffffffffff,\n"
+               "    fffffffffffff> {\n"
                "}");
 }
 
 TEST_F(FormatTestObjC, FormatObjCImplementation) {
   verifyFormat("@implementation Foo : NSObject {\n"
                "@public\n"
                "  int field1;\n"
                "@protected\n"