This is an archive of the discontinued LLVM Phabricator instance.

Differential D42632

Generate PDB files for profiling even in Release build
ClosedPublic

Authored by takuto.ikuta on Jan 28 2018, 10:07 PM.

Details

Reviewers
ruiu
zturner
Commits
rG876dc7124db1: Generate PDB files for profiling even in Release build.
rL324504: Generate PDB files for profiling even in Release build.
Summary

This patch enables PDB generation for Release build, which has slightly different optimize option with RelWithDebInfo on windows.

This helps to know slow part of Release build when profiling.

Diff Detail

Repository
rL LLVM

Event Timeline

takuto.ikuta created this revision.Jan 28 2018, 10:07 PM
Herald added subscribers: hintonda, mgorny. · View Herald TranscriptJan 28 2018, 10:07 PM
takuto.ikuta edited the summary of this revision. (Show Details)Jan 28 2018, 10:09 PM
takuto.ikuta added reviewers: ruiu, zturner.
takuto.ikuta updated this revision to Diff 131811.Jan 29 2018, 8:37 AM
takuto.ikuta retitled this revision from Add LLVM_ENABLE_PDB option for profile in Release build to Generate PDB files for profiling even in Release build.
zturner accepted this revision.Jan 29 2018, 10:59 AM

True, link time would probably be affected. But I think if anyone is concerned about this, they can add -DLLVM_DISABLE_PDB. Having it generate a PDB should be the default IMO.

This revision is now accepted and ready to land.Jan 29 2018, 10:59 AM
takuto.ikuta added a comment.Jan 29 2018, 1:39 PM

Thanks. Could you merge this patch instead of me? I don't have permission.

takuto.ikuta added a comment.Feb 7 2018, 8:21 AM

Ping?

Closed by commit rL324504: Generate PDB files for profiling even in Release build. (authored by zturner). · Explain WhyFeb 7 2018, 11:40 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptFeb 7 2018, 11:40 AM
takuto.ikuta added a comment.Feb 7 2018, 3:05 PM

Thank you!

rongjiecomputer added a subscriber: rongjiecomputer.Feb 8 2018, 5:29 AM

I don't see LLVM_DISABLE_PDB option being added anywhere, was it accidentally omitted in this patch?

I want to avoid producing .pdb as I have to fit building LLVM under 1 hour due to CI limitation and it already takes 53 minutes without producing .pdb.

thakis added a subscriber: thakis.Feb 8 2018, 6:46 AM
thakis added inline comments.
llvm/trunk/cmake/modules/HandleLLVMOptions.cmake
359

Doesn't /DEBUG disable /OPT:REF and /OPT:ICF by default? I think you probably want "/DEBUG /OPT:REF /OPT:ICF" instead of just "/DEBUG".

Revision Contents

PathSize
llvm/
trunk/
cmake/
modules/
6 lines

Diff 133269

llvm/trunk/cmake/modules/HandleLLVMOptions.cmake

Show First 20 Lines • Show All 347 Lines • ▼ Show 20 Linesif( MSVC )
) )
if (LLVM_ENABLE_WERROR) if (LLVM_ENABLE_WERROR)
append("/WX" CMAKE_C_FLAGS CMAKE_CXX_FLAGS) append("/WX" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
endif (LLVM_ENABLE_WERROR) endif (LLVM_ENABLE_WERROR)
append("/Zc:inline" CMAKE_C_FLAGS CMAKE_CXX_FLAGS) append("/Zc:inline" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
# Generate PDB even in release for profiling.
if (uppercase_CMAKE_BUILD_TYPE STREQUAL "RELEASE")
append("/Zi" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
append("/DEBUG" CMAKE_EXE_LINKER_FLAGS CMAKE_MODULE_LINKER_FLAGS CMAKE_SHARED_LINKER_FLAGS)
thakisUnsubmitted
Not Done
ReplyInline Actions

Doesn't /DEBUG disable /OPT:REF and /OPT:ICF by default? I think you probably want "/DEBUG /OPT:REF /OPT:ICF" instead of just "/DEBUG".

thakis: Doesn't /DEBUG disable /OPT:REF and /OPT:ICF by default? I think you probably want "/DEBUG /OPT…
endif (uppercase_CMAKE_BUILD_TYPE STREQUAL "RELEASE")
# /Zc:strictStrings is incompatible with VS12's (Visual Studio 2013's) # /Zc:strictStrings is incompatible with VS12's (Visual Studio 2013's)
# debug mode headers. Instead of only enabling them in VS2013's debug mode, # debug mode headers. Instead of only enabling them in VS2013's debug mode,
# we'll just enable them for Visual Studio 2015 (VS 14, MSVC_VERSION 1900) # we'll just enable them for Visual Studio 2015 (VS 14, MSVC_VERSION 1900)
# and up. # and up.
if (NOT (MSVC_VERSION LESS 1900)) if (NOT (MSVC_VERSION LESS 1900))
# Disable string literal const->non-const type conversion. # Disable string literal const->non-const type conversion.
# "When specified, the compiler requires strict const-qualification # "When specified, the compiler requires strict const-qualification
# conformance for pointers initialized by using string literals." # conformance for pointers initialized by using string literals."
▲ Show 20 Lines • Show All 507 Lines • Show Last 20 Lines