This is an archive of the discontinued LLVM Phabricator instance.

Differential D42336

Fix memory leaks in TestArm64InstEmulation
ClosedPublic

Authored by teemperor on Jan 20 2018, 1:17 PM.

Details

Reviewers
jasonmolenda
Commits
rGbb3c570633d6: Fix memory leaks in TestArm64InstEmulation
rLLDB323076: Fix memory leaks in TestArm64InstEmulation
rL323076: Fix memory leaks in TestArm64InstEmulation
Summary

We never delete the created instances, so those test fail with the memory sanitizer.

Diff Detail

Repository
rL LLVM

Event Timeline

teemperor created this revision.Jan 20 2018, 1:17 PM
Herald added subscribers: kristof.beyls, javed.absar, aemerson. · View Herald TranscriptJan 20 2018, 1:17 PM
jasonmolenda accepted this revision.Jan 21 2018, 4:20 PM

Thanks!

This revision is now accepted and ready to land.Jan 21 2018, 4:20 PM
Closed by commit rL323076: Fix memory leaks in TestArm64InstEmulation (authored by teemperor). · Explain WhyJan 21 2018, 11:23 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptJan 21 2018, 11:23 PM

Revision Contents

PathSize
lldb/
trunk/
unittests/
UnwindAssembly/
InstEmulation/
20 lines

Diff 130835

lldb/trunk/unittests/UnwindAssembly/InstEmulation/TestArm64InstEmulation.cpp

Show First 20 Lines • Show All 50 Lines • ▼ Show 20 Lines
void TestArm64InstEmulation::TearDownTestCase() { void TestArm64InstEmulation::TearDownTestCase() {
DisassemblerLLVMC::Terminate(); DisassemblerLLVMC::Terminate();
EmulateInstructionARM64::Terminate(); EmulateInstructionARM64::Terminate();
} }
TEST_F(TestArm64InstEmulation, TestSimpleDarwinFunction) { TEST_F(TestArm64InstEmulation, TestSimpleDarwinFunction) {
ArchSpec arch("arm64-apple-ios10"); ArchSpec arch("arm64-apple-ios10");
UnwindAssemblyInstEmulation *engine = std::unique_ptr<UnwindAssemblyInstEmulation> engine(
static_cast<UnwindAssemblyInstEmulation *>( static_cast<UnwindAssemblyInstEmulation *>(
UnwindAssemblyInstEmulation::CreateInstance(arch)); UnwindAssemblyInstEmulation::CreateInstance(arch)));
ASSERT_NE(nullptr, engine); ASSERT_NE(nullptr, engine);
UnwindPlan::RowSP row_sp; UnwindPlan::RowSP row_sp;
AddressRange sample_range; AddressRange sample_range;
UnwindPlan unwind_plan(eRegisterKindLLDB); UnwindPlan unwind_plan(eRegisterKindLLDB);
UnwindPlan::Row::RegisterLocation regloc; UnwindPlan::Row::RegisterLocation regloc;
// 'int main() { }' compiled for arm64-apple-ios with clang // 'int main() { }' compiled for arm64-apple-ios with clang
▲ Show 20 Lines • Show All 77 Lines • ▼ Show 20 LinesTEST_F(TestArm64InstEmulation, TestSimpleDarwinFunction) {
EXPECT_EQ(20ull, row_sp->GetOffset()); EXPECT_EQ(20ull, row_sp->GetOffset());
EXPECT_TRUE(row_sp->GetCFAValue().GetRegisterNumber() == gpr_sp_arm64); EXPECT_TRUE(row_sp->GetCFAValue().GetRegisterNumber() == gpr_sp_arm64);
EXPECT_TRUE(row_sp->GetCFAValue().IsRegisterPlusOffset() == true); EXPECT_TRUE(row_sp->GetCFAValue().IsRegisterPlusOffset() == true);
EXPECT_EQ(0, row_sp->GetCFAValue().GetOffset()); EXPECT_EQ(0, row_sp->GetCFAValue().GetOffset());
} }
TEST_F(TestArm64InstEmulation, TestMediumDarwinFunction) { TEST_F(TestArm64InstEmulation, TestMediumDarwinFunction) {
ArchSpec arch("arm64-apple-ios10"); ArchSpec arch("arm64-apple-ios10");
UnwindAssemblyInstEmulation *engine = std::unique_ptr<UnwindAssemblyInstEmulation> engine(
static_cast<UnwindAssemblyInstEmulation *>( static_cast<UnwindAssemblyInstEmulation *>(
UnwindAssemblyInstEmulation::CreateInstance(arch)); UnwindAssemblyInstEmulation::CreateInstance(arch)));
ASSERT_NE(nullptr, engine); ASSERT_NE(nullptr, engine);
UnwindPlan::RowSP row_sp; UnwindPlan::RowSP row_sp;
AddressRange sample_range; AddressRange sample_range;
UnwindPlan unwind_plan(eRegisterKindLLDB); UnwindPlan unwind_plan(eRegisterKindLLDB);
UnwindPlan::Row::RegisterLocation regloc; UnwindPlan::Row::RegisterLocation regloc;
// disassembly of -[NSPlaceholderString initWithBytes:length:encoding:] // disassembly of -[NSPlaceholderString initWithBytes:length:encoding:]
▲ Show 20 Lines • Show All 143 Lines • ▼ Show 20 LinesTEST_F(TestArm64InstEmulation, TestMediumDarwinFunction) {
EXPECT_TRUE(regloc.IsSame()); EXPECT_TRUE(regloc.IsSame());
EXPECT_TRUE(row_sp->GetRegisterInfo(gpr_x22_arm64, regloc)); EXPECT_TRUE(row_sp->GetRegisterInfo(gpr_x22_arm64, regloc));
EXPECT_TRUE(regloc.IsSame()); EXPECT_TRUE(regloc.IsSame());
} }
TEST_F(TestArm64InstEmulation, TestFramelessThreeEpilogueFunction) { TEST_F(TestArm64InstEmulation, TestFramelessThreeEpilogueFunction) {
ArchSpec arch("arm64-apple-ios10"); ArchSpec arch("arm64-apple-ios10");
UnwindAssemblyInstEmulation *engine = std::unique_ptr<UnwindAssemblyInstEmulation> engine(
static_cast<UnwindAssemblyInstEmulation *>( static_cast<UnwindAssemblyInstEmulation *>(
UnwindAssemblyInstEmulation::CreateInstance(arch)); UnwindAssemblyInstEmulation::CreateInstance(arch)));
ASSERT_NE(nullptr, engine); ASSERT_NE(nullptr, engine);
UnwindPlan::RowSP row_sp; UnwindPlan::RowSP row_sp;
AddressRange sample_range; AddressRange sample_range;
UnwindPlan unwind_plan(eRegisterKindLLDB); UnwindPlan unwind_plan(eRegisterKindLLDB);
UnwindPlan::Row::RegisterLocation regloc; UnwindPlan::Row::RegisterLocation regloc;
// disassembly of JSC::ARM64LogicalImmediate::findBitRange<16u> // disassembly of JSC::ARM64LogicalImmediate::findBitRange<16u>
▲ Show 20 Lines • Show All 76 Lines • ▼ Show 20 LinesTEST_F(TestArm64InstEmulation, TestFramelessThreeEpilogueFunction) {
row_sp = unwind_plan.GetRowForFunctionOffset(60); row_sp = unwind_plan.GetRowForFunctionOffset(60);
EXPECT_TRUE(row_sp->GetCFAValue().GetRegisterNumber() == gpr_sp_arm64); EXPECT_TRUE(row_sp->GetCFAValue().GetRegisterNumber() == gpr_sp_arm64);
EXPECT_TRUE(row_sp->GetCFAValue().IsRegisterPlusOffset() == true); EXPECT_TRUE(row_sp->GetCFAValue().IsRegisterPlusOffset() == true);
EXPECT_EQ(0, row_sp->GetCFAValue().GetOffset()); EXPECT_EQ(0, row_sp->GetCFAValue().GetOffset());
} }
TEST_F(TestArm64InstEmulation, TestRegisterSavedTwice) { TEST_F(TestArm64InstEmulation, TestRegisterSavedTwice) {
ArchSpec arch("arm64-apple-ios10"); ArchSpec arch("arm64-apple-ios10");
UnwindAssemblyInstEmulation *engine = std::unique_ptr<UnwindAssemblyInstEmulation> engine(
static_cast<UnwindAssemblyInstEmulation *>( static_cast<UnwindAssemblyInstEmulation *>(
UnwindAssemblyInstEmulation::CreateInstance(arch)); UnwindAssemblyInstEmulation::CreateInstance(arch)));
ASSERT_NE(nullptr, engine); ASSERT_NE(nullptr, engine);
UnwindPlan::RowSP row_sp; UnwindPlan::RowSP row_sp;
AddressRange sample_range; AddressRange sample_range;
UnwindPlan unwind_plan(eRegisterKindLLDB); UnwindPlan unwind_plan(eRegisterKindLLDB);
UnwindPlan::Row::RegisterLocation regloc; UnwindPlan::Row::RegisterLocation regloc;
// disassembly of mach_msg_sever_once from libsystem_kernel.dylib for iOS. // disassembly of mach_msg_sever_once from libsystem_kernel.dylib for iOS.
▲ Show 20 Lines • Show All 83 Lines • ▼ Show 20 LinesTEST_F(TestArm64InstEmulation, TestRegisterSavedTwice) {
EXPECT_TRUE(row_sp->GetRegisterInfo(gpr_x20_arm64, regloc)); EXPECT_TRUE(row_sp->GetRegisterInfo(gpr_x20_arm64, regloc));
EXPECT_TRUE(regloc.IsAtCFAPlusOffset()); EXPECT_TRUE(regloc.IsAtCFAPlusOffset());
EXPECT_EQ(-32, regloc.GetOffset()); EXPECT_EQ(-32, regloc.GetOffset());
} }
TEST_F(TestArm64InstEmulation, TestRegisterDoubleSpills) { TEST_F(TestArm64InstEmulation, TestRegisterDoubleSpills) {
ArchSpec arch("arm64-apple-ios10"); ArchSpec arch("arm64-apple-ios10");
UnwindAssemblyInstEmulation *engine = std::unique_ptr<UnwindAssemblyInstEmulation> engine(
static_cast<UnwindAssemblyInstEmulation *>( static_cast<UnwindAssemblyInstEmulation *>(
UnwindAssemblyInstEmulation::CreateInstance(arch)); UnwindAssemblyInstEmulation::CreateInstance(arch)));
ASSERT_NE(nullptr, engine); ASSERT_NE(nullptr, engine);
UnwindPlan::RowSP row_sp; UnwindPlan::RowSP row_sp;
AddressRange sample_range; AddressRange sample_range;
UnwindPlan unwind_plan(eRegisterKindLLDB); UnwindPlan unwind_plan(eRegisterKindLLDB);
UnwindPlan::Row::RegisterLocation regloc; UnwindPlan::Row::RegisterLocation regloc;
// this file built with clang for iOS arch arm64 optimization -Os // this file built with clang for iOS arch arm64 optimization -Os
▲ Show 20 Lines • Show All 148 Lines • Show Last 20 Lines